[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Check max viewport and texture dimensions for glViewport
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-11-08 21:10:17
Message-ID: 20121108211017.2753.47537 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106917/
-----------------------------------------------------------
(Updated Nov. 8, 2012, 9:10 p.m.)
Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
Changes
-------
- Open compositing kcm
- refer to it
- sexy up dialog (ok, more the "in your face" approach, because users won't=
read it otherwise :-(
Description
-------
The patch checks
1. whether the requested dimension is beyond the propagated viewport capabi=
lities (and in case toggles compositing with a sorry)
2. Because recently MESA is a bit enthusiastic about the capabilities, also=
whether the requested dimension is beyond the propagated texture capabilit=
ies (and in case informs the user that this could or will lead to trouble, =
think of "maximized" windows)
Diffs (updated)
-----
kwin/scene_opengl.h fe4f1b5 =
kwin/scene_opengl.cpp 290477f =
Diff: http://git.reviewboard.kde.org/r/106917/diff/
Testing
-------
Constrained the limits to "5" and either dropped out of compositing with th=
e dialog or got the information dialog. "Do not show again" works as well. =
Dialog code is largely stolen from useractions.cpp.
Thanks,
Thomas L=C3=BCbking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106917/">http://git.reviewboard.kde.org/r/106917/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2012, 9:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Open compositing kcm
- refer to it
- sexy up dialog (ok, more the "in your face" approach, because users \
won't read it otherwise :-(</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch checks 1. whether the requested dimension is beyond the \
propagated viewport capabilities (and in case toggles compositing with a sorry) 2. \
Because recently MESA is a bit enthusiastic about the capabilities, also whether the \
requested dimension is beyond the propagated texture capabilities (and in case \
informs the user that this could or will lead to trouble, think of \
"maximized" windows)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constrained the limits to "5" and either dropped out of \
compositing with the dialog or got the information dialog. "Do not show \
again" works as well. Dialog code is largely stolen from useractions.cpp.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scene_opengl.h <span style="color: grey">(fe4f1b5)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(290477f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic