[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Implement color correction (per output)
From: "Casian Andrei" <skeletk13 () gmail ! com>
Date: 2012-10-28 10:35:33
Message-ID: 20121028103533.18016.84704 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 27, 2012, 3:52 p.m., Fredrik Höglund wrote:
> >
Thanks for the refresh.
> On Oct. 27, 2012, 3:52 p.m., Fredrik Höglund wrote:
> > kwin/libkwineffects/kwinglcolorcorrection.cpp, line 238
> > <http://git.reviewboard.kde.org/r/106141/diff/3/?file=92497#file92497line238>
> >
> > Is the min() call here really necessary?
It appears it was only necessary when that forceAlpha was left like "tex.a += \
float(u_forceAlpha)" in the fragment shader. This made alpha to be greater than one \
sometimes. I have now removed the min() call.
> On Oct. 27, 2012, 3:52 p.m., Fredrik Höglund wrote:
> > kwin/scene-fragment.glsl, line 13
> > <http://git.reviewboard.kde.org/r/106141/diff/3/?file=92505#file92505line13>
> >
> > This line was originally added to work around an issue with the NVIDIA driver \
> > where the alpha values wouldn't be set to 1 when blitting pixels from a GL_RGB \
> > buffer to a GL_RGBA texture.
> > It doesn't appear to be reproducible with the current version of the driver, so \
> > all code related to u_forceAlpha can probably be removed.
Ok, I will come up with a separate review request for this. However, I don't have any \
NVIDIA cards around for testing.
> On Oct. 27, 2012, 3:52 p.m., Fredrik Höglund wrote:
> > kwin/libkwineffects/kwinglutils.cpp, line 319
> > <http://git.reviewboard.kde.org/r/106141/diff/3/?file=92502#file92502line319>
> >
> > As far as I can tell this code still has the issue that it applies the color \
> > correction to all shaders unconditionally.
Unfortunately I still don't understand what this issue is about. Let me explain how I \
understand things:
When color correction is enabled, the following code is put in all fragment shaders \
unconditionally: uniform sampler3D u_ccLookupTexture;
gl_FragColor.rgb = texture3D(u_ccLookupTexture, gl_FragColor.rgb / \
gl_FragColor.a).rgb;
When KWin draws a window or something for one output, it tells the color correction \
code, which sets up u_ccLookupTexture accordingly, this way enabling color \
correction. In all other cases (like some effect using a special fragment shader for \
doing it's specialized magic), the texture associated with u_ccLookupTexture is a \
dummy color lookup texture i.e. does nothing, no color correction.
So, color correction is done only when KWin wants it, like for drawing for a color \
corrected output (this can be traced to ColorCorrection::setupForOutput(), which is \
done in SceneOpenGL2Window::beginRenderWindow() and prepareStates()).
True, when no color correction is needed for drawing something and color correction \
is enabled, there is an overhead in that fragment shader. But I don't know how to \
easily solve this. Perhaps it can be done with an extra parameter in these GLShader \
methods, but isn't that too many complications for this kind of overhead?
This issue could occur when something draws a window, buffers the drawing, and then \
somehow draws again a window with the drawings of the first one inside. Can this \
happen? I don't know, but if this is the case, I think it could be avoided by \
altering WindowPaintData (and making some small modifications in \
SceneOpenGL2::finalDrawWindow).
Well, I might be missing something since I don't know all the details of the KWin \
rendering operations. In this case, some further clarifications on the issue would \
enlighten me.
- Casian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106141/#review21007
-----------------------------------------------------------
On Oct. 27, 2012, 9:56 a.m., Casian Andrei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106141/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2012, 9:56 a.m.)
>
>
> Review request for kwin, Thomas Lübking and Martin Gräßlin.
>
>
> Description
> -------
>
> These are the results of my GSoC project, for KWin.
>
> This color correction needs KolorManager installed, master branch. That one needs \
> Oyranos and additional color management dependencies. \
> git://anongit.kde.org/kolor-manager.git http://www.oyranos.org/downloads
> If it's not installed, the ColorCorrection class should fail without causing any \
> issues to the user (that's if it's enabled from the KCM). Probably a notification \
> could be appropriate in that case? "Failed to initialize CC because cannot contact \
> Kolor-Server KDED..." something like that?
> Change summary:
> --
> Add an option to kcmcompositing in the 'Advanced' tab, to enable or disable color \
> correction. It is specified that it's experimental and it needs Kolor Manager. This \
> implies some small changes to options.h and cpp.
> Scene::finalPaintWindow code is moved into SceneOpenGL::performPaint.
> SceneOpenGL has the declarations of some methods changed to include the screen \
> number - those could be changed to pass around PaintData's probably. SceneOpenGL's \
> newly implemented finalDrawWindow splits the rendering if color correction is \
> enabled and there are multiple screens. Before painting for a particular screen, \
> ColorCorrection::setupForOutput should be called.
> There was a problem with the blending function causing artifacts with color \
> correction enabled so it is set up to src_alpha, one_minus_src alpha in that case.
> Now, inside KWinEffects:
> --
> A screen property is added for WindowPaintData.
> In kwinglutils, The fragment shaders are intercepted before being compiled and they \
> get a couple of lines of code inserted in order to do the color stuff. This happens \
> only when color correction is enabled, of course.
> And there is the big ColorCorrection class. The public and private stuff are well \
> separated.
> The private stuff consists of the private data and the D-Bus interface. Regarding \
> D-Bus, everything is async.
> The implementation basically manages a set of color lookup tables for different \
> outputs and for different window regions. These are taken via D-Bus. Each lookup \
> table has around 700 KB. I hope I am not wrong in assuming it's not that big of an \
> issue time-wise, since they are transferred only once or twice for an entire \
> session. I hope D-Bus doesn't do any time consuming business to transfer those \
> QVector's.
> In case of problems, it should not affect the rest of KWin in any way.
>
> Next priorities:
> --
> Implement per-window-region stuff. It should be a matter of extending KolorServer's \
> capabilities and doing some small modifications in SceneOpenGL::Window. The \
> ColorCorrection class from KWinEffects has everything prepared.
>
> Diffs
> -----
>
> kwin/kcmkwin/kwincompositing/main.cpp 7a89db4
> kwin/kcmkwin/kwincompositing/main.ui cff0f63
> kwin/libkwineffects/CMakeLists.txt f95d40e
> kwin/libkwineffects/kwineffects.h eb09d51
> kwin/libkwineffects/kwineffects.cpp 9cd9987
> kwin/libkwineffects/kwinglcolorcorrection.h PRE-CREATION
> kwin/libkwineffects/kwinglcolorcorrection.cpp PRE-CREATION
> kwin/libkwineffects/kwinglcolorcorrection_p.h PRE-CREATION
> kwin/libkwineffects/kwinglplatform.h 249ecdb
> kwin/libkwineffects/kwinglplatform.cpp 59ce7b2
> kwin/libkwineffects/kwinglutils.h 9b175b9
> kwin/libkwineffects/kwinglutils.cpp da0e7cc
> kwin/options.h 8069d7b
> kwin/options.cpp 50db58d
> kwin/scene-fragment.glsl 4b5424b
> kwin/scene.h be3acc4
> kwin/scene.cpp 28136b6
> kwin/scene_opengl.h dce2b7c
> kwin/scene_opengl.cpp 3f130b9
>
> Diff: http://git.reviewboard.kde.org/r/106141/diff/
>
>
> Testing
> -------
>
> Restarted KDED making sure Kolor-Manager is installed properly - this should make \
> the KDED module available.
> Restarted KWin, enabled color correction in KCM compositing, advanced tab.
>
> Played a bit with commands like:
> oyranos-monitor -d 0 XYZ.icc
> oyranos-monitor -d 1 Lab.icc
> Those set up particular profiles for the monitors. However, it seems there is a \
> problem with reverting to the normal ones. The code regarding that is taken \
> directly from CompICC, so I don't know whether it's a bug or a feature. Anyway, \
> it's from Kolor-Server.
> Apparently, everything works as planned. But I cannot distinguish visible \
> differences for the profiles used for the different monitors by default.
>
> After testing with the newest Oyranos, there is an issue at login, the custom color \
> profiles are not loaded at first because of an issue in Oyranos probably. It will \
> be fixed soon.
>
> Screenshots
> -----------
>
> Output 0 Lab.icc Output 1 XYZ.icc
> http://git.reviewboard.kde.org/r/106141/s/695/
>
>
> Thanks,
>
> Casian Andrei
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106141/">http://git.reviewboard.kde.org/r/106141/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the \
refresh.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 27th, 2012, 3:52 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106141/diff/3/?file=92497#file92497line238" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkwineffects/kwinglcolorcorrection.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static const char s_ccAlteration[] =</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">238</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"gl_FragColor.rgb = texture3D(u_ccLookupTexture, gl_FragColor.rgb / \
min(gl_FragColor.a, 1.0)).rgb;</span><span class="se">\n</span><span \
class="s">"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the min() call here \
really necessary?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It appears \
it was only necessary when that forceAlpha was left like "tex.a += \
float(u_forceAlpha)" in the fragment shader. This made alpha to be greater than \
one sometimes. I have now removed the min() call.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 27th, 2012, 3:52 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106141/diff/3/?file=92502#file92502line319" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkwineffects/kwinglutils.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
GLShader::loadFromFiles(const QString &vertexFile, const QString \
&fragmentFile)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">316</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="kt">char</span><span class="o">*</span> <span \
class="n">src</span> <span class="o">=</span> <span class="n">ba</span><span \
class="p">.</span><span class="n">constData</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">317</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1">// Inject color correction \
code for fragment shaders, if possible</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I can tell \
this code still has the issue that it applies the color correction to all shaders \
unconditionally.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unfortunately I still don't understand what this issue is about. Let \
me explain how I understand things:
When color correction is enabled, the following code is put in all fragment shaders \
unconditionally: uniform sampler3D u_ccLookupTexture;
gl_FragColor.rgb = texture3D(u_ccLookupTexture, gl_FragColor.rgb / \
gl_FragColor.a).rgb;
When KWin draws a window or something for one output, it tells the color correction \
code, which sets up u_ccLookupTexture accordingly, this way enabling color \
correction. In all other cases (like some effect using a special fragment shader for \
doing it's specialized magic), the texture associated with u_ccLookupTexture is a \
dummy color lookup texture i.e. does nothing, no color correction.
So, color correction is done only when KWin wants it, like for drawing for a color \
corrected output (this can be traced to ColorCorrection::setupForOutput(), which is \
done in SceneOpenGL2Window::beginRenderWindow() and prepareStates()).
True, when no color correction is needed for drawing something and color correction \
is enabled, there is an overhead in that fragment shader. But I don't know how to \
easily solve this. Perhaps it can be done with an extra parameter in these GLShader \
methods, but isn't that too many complications for this kind of overhead?
This issue could occur when something draws a window, buffers the drawing, and then \
somehow draws again a window with the drawings of the first one inside. Can this \
happen? I don't know, but if this is the case, I think it could be avoided by \
altering WindowPaintData (and making some small modifications in \
SceneOpenGL2::finalDrawWindow).
Well, I might be missing something since I don't know all the details of the KWin \
rendering operations. In this case, some further clarifications on the issue would \
enlighten me. </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 27th, 2012, 3:52 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106141/diff/3/?file=92505#file92505line13" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scene-fragment.glsl</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">13</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> tex.a <span \
class="hl">+=</span> float(u_forceAlpha);</pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">13</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> tex.a <span class="hl">= \
min(tex.a +</span> float(u_forceAlpha)<span class="hl">, 1.0)</span>;</pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line was originally \
added to work around an issue with the NVIDIA driver where the alpha values \
wouldn't be set to 1 when blitting pixels from a GL_RGB buffer to a GL_RGBA \
texture.
It doesn't appear to be reproducible with the current version of the driver, so \
all code related to u_forceAlpha can probably be removed. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I will \
come up with a separate review request for this. However, I don't have any NVIDIA \
cards around for testing.</pre> <br />
<p>- Casian</p>
<br />
<p>On October 27th, 2012, 9:56 a.m., Casian Andrei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking and Martin Gräßlin.</div>
<div>By Casian Andrei.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2012, 9:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are the results of my GSoC project, for KWin.
This color correction needs KolorManager installed, master branch. That one needs \
Oyranos and additional color management dependencies. \
git://anongit.kde.org/kolor-manager.git http://www.oyranos.org/downloads
If it's not installed, the ColorCorrection class should fail without causing any \
issues to the user (that's if it's enabled from the KCM). Probably a \
notification could be appropriate in that case? "Failed to initialize CC because \
cannot contact Kolor-Server KDED..." something like that?
Change summary:
--
Add an option to kcmcompositing in the 'Advanced' tab, to enable or disable \
color correction. It is specified that it's experimental and it needs Kolor \
Manager. This implies some small changes to options.h and cpp.
Scene::finalPaintWindow code is moved into SceneOpenGL::performPaint.
SceneOpenGL has the declarations of some methods changed to include the screen number \
- those could be changed to pass around PaintData's probably. SceneOpenGL's \
newly implemented finalDrawWindow splits the rendering if color correction is enabled \
and there are multiple screens. Before painting for a particular screen, \
ColorCorrection::setupForOutput should be called.
There was a problem with the blending function causing artifacts with color \
correction enabled so it is set up to src_alpha, one_minus_src alpha in that case.
Now, inside KWinEffects:
--
A screen property is added for WindowPaintData.
In kwinglutils, The fragment shaders are intercepted before being compiled and they \
get a couple of lines of code inserted in order to do the color stuff. This happens \
only when color correction is enabled, of course.
And there is the big ColorCorrection class. The public and private stuff are well \
separated.
The private stuff consists of the private data and the D-Bus interface. Regarding \
D-Bus, everything is async.
The implementation basically manages a set of color lookup tables for different \
outputs and for different window regions. These are taken via D-Bus. Each lookup \
table has around 700 KB. I hope I am not wrong in assuming it's not that big of \
an issue time-wise, since they are transferred only once or twice for an entire \
session. I hope D-Bus doesn't do any time consuming business to transfer those \
QVector's.
In case of problems, it should not affect the rest of KWin in any way.
Next priorities:
--
Implement per-window-region stuff. It should be a matter of extending \
KolorServer's capabilities and doing some small modifications in \
SceneOpenGL::Window. The ColorCorrection class from KWinEffects has everything \
prepared. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Restarted KDED making sure Kolor-Manager is installed properly - this \
should make the KDED module available.
Restarted KWin, enabled color correction in KCM compositing, advanced tab.
Played a bit with commands like:
oyranos-monitor -d 0 XYZ.icc
oyranos-monitor -d 1 Lab.icc
Those set up particular profiles for the monitors. However, it seems there is a \
problem with reverting to the normal ones. The code regarding that is taken directly \
from CompICC, so I don't know whether it's a bug or a feature. Anyway, \
it's from Kolor-Server.
Apparently, everything works as planned. But I cannot distinguish visible differences \
for the profiles used for the different monitors by default.
After testing with the newest Oyranos, there is an issue at login, the custom color \
profiles are not loaded at first because of an issue in Oyranos probably. It will be \
fixed soon.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(7a89db4)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.ui <span style="color: \
grey">(cff0f63)</span></li>
<li>kwin/libkwineffects/CMakeLists.txt <span style="color: \
grey">(f95d40e)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(eb09d51)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(9cd9987)</span></li>
<li>kwin/libkwineffects/kwinglcolorcorrection.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/libkwineffects/kwinglcolorcorrection.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/libkwineffects/kwinglcolorcorrection_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/libkwineffects/kwinglplatform.h <span style="color: \
grey">(249ecdb)</span></li>
<li>kwin/libkwineffects/kwinglplatform.cpp <span style="color: \
grey">(59ce7b2)</span></li>
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(9b175b9)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(da0e7cc)</span></li>
<li>kwin/options.h <span style="color: grey">(8069d7b)</span></li>
<li>kwin/options.cpp <span style="color: grey">(50db58d)</span></li>
<li>kwin/scene-fragment.glsl <span style="color: grey">(4b5424b)</span></li>
<li>kwin/scene.h <span style="color: grey">(be3acc4)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(28136b6)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(dce2b7c)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(3f130b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106141/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106141/s/695/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/23/cc_alter_6_400x100.png" \
style="border: 1px black solid;" alt="Output 0 Lab.icc Output 1 XYZ.icc" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic