[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add appmenu support to kwin
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-10-26 16:49:46
Message-ID: 20121026164946.4462.37163 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 22, 2012, 1:37 p.m., Bellegarde Cédric wrote:
> > What to do with this ?
> >
> > If it's not going to be accepted, i think i need to remove quickly kded-appmenu \
> > from kde-workspace.git (before freeze).
>
> Martin Gräßlin wrote:
> I want to see it go into 4.10. Haven't tested the latest diff yet, but as far as I \
> remember most have been rather minor issues, right?
> Bellegarde Cédric wrote:
> «Tomorrow 25 October 2012 is the Soft Feature Freeze for KDE SC 4.10 »
>
> No response for now, will remove kded-appmenu tomorrow...
>
> Martin Gräßlin wrote:
> why? The soft feature freeze does not mean you have to remove that. You have all \
> the time till the hard feature freeze to get it in.
> Bellegarde Cédric wrote:
> Because the patch isn't present in the repository (no Ship it here)... Only \
> kded-appmenu is present so it only allow menu export, topmenubar but no button in \
> titlebar and no configuration dialog.
"The soft feature freeze does not mean you have to remove that.
You have all the time till the hard feature freeze to get it in."
Maybe pass that though a dictionary?
The feature needs to be commited: Fr 9. Nov 00:59:00 CET 2012
For now it's entirely sufficient to just have stated: "this shall be in".
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review20677
-----------------------------------------------------------
On Oct. 9, 2012, 8:51 a.m., Bellegarde Cédric wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104344/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2012, 8:51 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Here a patch to add appmenu support to kwin via a menu button in titlebar
>
> Works by Lionel Chauvin and me, original review request: \
> https://git.reviewboard.kde.org/r/101162/
> It depends on:
> http://quickgit.kde.org/index.php?p=kded-appmenu.git
>
> It looks like this:
> https://www.youtube.com/watch?v=x1bm7Q6_SH4&hd=1
>
> New version, all drawing code moved to kded-appmenu as asked.
>
>
> Diffs
> -----
>
> kcontrol/style/CMakeLists.txt cbab94d
> kcontrol/style/finetuning.ui 2d384bc
> kcontrol/style/kcmstyle.h cd1472f
> kcontrol/style/kcmstyle.cpp 849a49b
> kwin/CMakeLists.txt 95fb9c9
> kwin/bridge.h 64108e5
> kwin/bridge.cpp 6dbf1bd
> kwin/client.h 130a67a
> kwin/client.cpp 07ffe03
> kwin/clients/oxygen/oxygenbutton.h ea11717
> kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
> kwin/clients/oxygen/oxygenclient.cpp 0b39d7d
> kwin/clients/oxygen/oxygenfactory.h b38b097
> kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
> kwin/config-kwin.h.cmake c48f569
> kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
> kwin/kcmkwin/kwindecoration/preview.h 52645fd
> kwin/kcmkwin/kwindecoration/preview.cpp 587df7c
> kwin/libkdecorations/kcommondecoration.h 3fe9fcf
> kwin/libkdecorations/kcommondecoration.cpp e3e884b
> kwin/libkdecorations/kdecoration.h 7b1f3e0
> kwin/libkdecorations/kdecoration.cpp 71f4f8d
> kwin/libkdecorations/kdecorationbridge.h b7d0619
> kwin/useractions.cpp 8fcdba2
> kwin/workspace.h c4fd281
> kwin/workspace.cpp e86e39e
>
> Diff: http://git.reviewboard.kde.org/r/104344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bellegarde Cédric
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104344/">http://git.reviewboard.kde.org/r/104344/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 22nd, 2012, 1:37 p.m., <b>Bellegarde \
Cédric</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What to do with this ?
If it's not going to be accepted, i think i need to remove quickly kded-appmenu \
from kde-workspace.git (before freeze).</pre> </blockquote>
<p>On October 22nd, 2012, 3:40 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I want to see it go into \
4.10. Haven't tested the latest diff yet, but as far as I remember most have been \
rather minor issues, right?</pre> </blockquote>
<p>On October 25th, 2012, 7:07 a.m., <b>Bellegarde Cédric</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> «Tomorrow 25 October \
2012 is the Soft Feature Freeze for KDE SC 4.10 »
No response for now, will remove kded-appmenu tomorrow...</pre>
</blockquote>
<p>On October 25th, 2012, 8:35 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why? The soft feature \
freeze does not mean you have to remove that. You have all the time till the hard \
feature freeze to get it in.</pre> </blockquote>
<p>On October 26th, 2012, 3:12 p.m., <b>Bellegarde Cédric</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because the patch \
isn't present in the repository (no Ship it here)... Only kded-appmenu is present \
so it only allow menu export, topmenubar but no button in titlebar and no \
configuration dialog.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"The soft feature \
freeze does not mean you have to remove that. You have all the time till the hard \
feature freeze to get it in."
Maybe pass that though a dictionary?
The feature needs to be commited: Fr 9. Nov 00:59:00 CET 2012
For now it's entirely sufficient to just have stated: "this shall be \
in".</pre> <br />
<p>- Thomas</p>
<br />
<p>On October 9th, 2012, 8:51 a.m., Bellegarde Cédric wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Bellegarde Cédric.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2012, 8:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here a patch to add appmenu support to kwin via a menu button in \
titlebar
Works by Lionel Chauvin and me, original review request: \
https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
It looks like this:
https://www.youtube.com/watch?v=x1bm7Q6_SH4&hd=1
New version, all drawing code moved to kded-appmenu as asked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(cbab94d)</span></li>
<li>kcontrol/style/finetuning.ui <span style="color: grey">(2d384bc)</span></li>
<li>kcontrol/style/kcmstyle.h <span style="color: grey">(cd1472f)</span></li>
<li>kcontrol/style/kcmstyle.cpp <span style="color: grey">(849a49b)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(95fb9c9)</span></li>
<li>kwin/bridge.h <span style="color: grey">(64108e5)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(6dbf1bd)</span></li>
<li>kwin/client.h <span style="color: grey">(130a67a)</span></li>
<li>kwin/client.cpp <span style="color: grey">(07ffe03)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.h <span style="color: \
grey">(ea11717)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.cpp <span style="color: \
grey">(28aa8b1)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(0b39d7d)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(b38b097)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(5502a6a)</span></li>
<li>kwin/config-kwin.h.cmake <span style="color: grey">(c48f569)</span></li>
<li>kwin/kcmkwin/kwindecoration/buttons.cpp <span style="color: \
grey">(2d12244)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(52645fd)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(587df7c)</span></li>
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(3fe9fcf)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(e3e884b)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(7b1f3e0)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(b7d0619)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(8fcdba2)</span></li>
<li>kwin/workspace.h <span style="color: grey">(c4fd281)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(e86e39e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104344/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic