'Re: Review Request: Detect latest Intel hardware in GLPlatform'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Detect latest Intel hardware in GLPlatform
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-10-16 4:24:32
Message-ID: 20121016042432.10468.68135 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Oct. 15, 2012, 10:42 p.m., Kai Uwe Broulik wrote:
> > I have a IvyBridge Intel GMA. What should I notice when testing this pa=
tch?

nothing :-) The IvyBridge part is already tested and works

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106819/#review20443
-----------------------------------------------------------

On Oct. 13, 2012, 6:37 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106819/
> -----------------------------------------------------------
> =

> (Updated Oct. 13, 2012, 6:37 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Detect latest Intel hardware in GLPlatform
> =

> Added support for IvyBridge and Haswell.
> =

> I also wanted to extend radeon and nouveau detection, but so far failed t=
o find it in the source base. @Fredrik: do you know where I have to look at?
> =

> =

> Diffs
> -----
> =

>   kwin/libkwineffects/kwinglplatform.h cda141d9f9c87210e048df6629ed21e35e=
97b724 =

>   kwin/libkwineffects/kwinglplatform.cpp d5d498bf12c7c6c1da81333b45e3b9e7=
e96fb3f6 =

> =

> Diff: http://git.reviewboard.kde.org/r/106819/diff/
> =

> =

> Testing
> -------
> =

> It compiles, more I cannot test due to lack of hardware
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106819/">http://git.reviewboard.kde.org/r/106819/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 15th, 2012, 10:42 p.m., <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have a IvyBridge Intel GMA. What should I notice when testing this \
patch?</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nothing :-) The \
IvyBridge part is already tested and works</pre> <br />

<p>- Martin</p>

<br />
<p>On October 13th, 2012, 6:37 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Oct. 13, 2012, 6:37 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Detect latest Intel hardware in GLPlatform

Added support for IvyBridge and Haswell.

I also wanted to extend radeon and nouveau detection, but so far failed to find it in \
the source base. @Fredrik: do you know where I have to look at?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, more I cannot test due to lack of hardware</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglplatform.h <span style="color: \
grey">(cda141d9f9c87210e048df6629ed21e35e97b724)</span></li>

 <li>kwin/libkwineffects/kwinglplatform.cpp <span style="color: \
grey">(d5d498bf12c7c6c1da81333b45e3b9e7e96fb3f6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106819/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 