'Re: Review Request: Add appmenu support to kwin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Add appmenu support to kwin
From:       Bellegarde_Cédric <gnumdk () gmail ! com>
Date:       2012-10-05 15:40:04
Message-ID: 20121005154004.24681.71657 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Oct. 5, 2012, 2:54 p.m., Aaron J. Seigo wrote:
> > kcontrol/style/kcmstyle.cpp, line 433
> > <http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line433>
> > 
> > need, not needs :)
> > 
> > or perhaps:
> > 
> > "Menu bar settings changes will take effect only on application restart."
> > 
> > this should also be done as a proper notification using KNotify rather than a \
> > manual dbus call, as that is subject to change (both over time and on different \
> > platforms)

I tried to use Knotify but it wants me to modify /usr/share/apps/kde/kde.notifyrc \
from kde-runtime. Don't know why... A way to fix this ?

> On Oct. 5, 2012, 2:54 p.m., Aaron J. Seigo wrote:
> > kcontrol/style/kcmstyle.cpp, lines 267-270
> > <http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line267>
> > 
> > this is fine for developers, but fairly meaningless for most others. it also \
> > means that if a distribution decides not to install appmenu-qt for whatever \
> > reason, they get a nasty little message for their users (reality -> they'll just \
> > patch this out :) 
> > instead, i would suggest hiding the config UI if appmenu-qt is unavailable.

Ok, will fix this.

> On Oct. 5, 2012, 2:54 p.m., Aaron J. Seigo wrote:
> > kcontrol/style/kcmstyle.cpp, line 824
> > <http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line824>
> > 
> > the kded module seems to expect the group to be named "Menubar style" and a \
> > config key of "MenuBarStyle" ..  
> > i simply did a kdesrc-build kded-appmenu which pulled the repository from \
> > kdereview. i confirmed this is the same repo as listed on projects.kde.org .. is \
> > this not the correct repository, and if not, could you please update it? :)

I have merged kded-appmenu in kde-workspace.git, as asked by Martin.

kded-appmenu.git is the version i maintain for KDE 4.9 users. And so options is the \
one i used in my old patch.

http://quickgit.kde.org/index.php?p=kde-workspace.git&a=commit&h=455dbea1e1775c71e4d6c24431b918c8b4872f91

> On Oct. 5, 2012, 2:54 p.m., Aaron J. Seigo wrote:
> > kwin/clients/oxygen/oxygenclient.cpp, lines 212-216
> > <http://git.reviewboard.kde.org/r/104344/diff/21/?file=88394#file88394line212>
> > 
> > this now appears visually a bit reversed:
> > 
> > the application specific menu appears under a generic menu icon and the generic \
> > window actions appears under the window's (specific) icons :) 
> > i'd recommend that, at least if App Menu is turned on, the application menu \
> > appear in the button with the window's icon. 
> > alternatively, instead of a completely separate button, these 2 buttons could be \
> > merged into 1, with the window actions menu becoming a submenu (perhaps at the \
> > end of the menu?) and the app menu populating the rest of the menu. 
> > this limits the # of buttons and resolves the generic/specific icon issue AND as \
> > an extra special bonus it gives the menu a keyboard shortcut!

It's not possible, we remove menu drawing from kwin and put it in kded-module... 
Kwin just do a dbus call: org.kde.kded /modules/appmenu org.kde.kded.showMenu(int x, \
int y, qulonglong WId)

Maybe renaming "Window Menu" to "Window actions" may fix issue ?

- Bellegarde

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review19968
-----------------------------------------------------------

On Oct. 4, 2012, 11:27 a.m., Bellegarde Cédric wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104344/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 11:27 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Here a patch to add appmenu support to kwin via a menu button in titlebar
> 
> Works by Lionel Chauvin and me, original review request: \
> https://git.reviewboard.kde.org/r/101162/ 
> It depends on:
> http://quickgit.kde.org/index.php?p=kded-appmenu.git
> 
> It looks like this:
> https://www.youtube.com/watch?v=x1bm7Q6_SH4&hd=1
> 
> New version, all drawing code moved to kded-appmenu as asked.
> 
> 
> Diffs
> -----
> 
> kcontrol/style/finetuning.ui 2d384bc 
> kcontrol/style/kcmstyle.h cd1472f 
> kcontrol/style/kcmstyle.cpp 849a49b 
> kwin/CMakeLists.txt 458c341 
> kwin/bridge.h 64108e5 
> kwin/bridge.cpp 6dbf1bd 
> kwin/client.h 130a67a 
> kwin/client.cpp 07ffe03 
> kwin/clients/oxygen/oxygenbutton.h ea11717 
> kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1 
> kwin/clients/oxygen/oxygenclient.cpp 0b39d7d 
> kwin/clients/oxygen/oxygenfactory.h b38b097 
> kwin/clients/oxygen/oxygenfactory.cpp 5502a6a 
> kwin/config-kwin.h.cmake e5ed2a6 
> kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244 
> kwin/kcmkwin/kwindecoration/preview.h 52645fd 
> kwin/kcmkwin/kwindecoration/preview.cpp 587df7c 
> kwin/libkdecorations/kcommondecoration.h 3fe9fcf 
> kwin/libkdecorations/kcommondecoration.cpp e3e884b 
> kwin/libkdecorations/kdecoration.h 7b1f3e0 
> kwin/libkdecorations/kdecoration.cpp 71f4f8d 
> kwin/libkdecorations/kdecorationbridge.h b7d0619 
> kwin/useractions.cpp 8fcdba2 
> kwin/workspace.h c4fd281 
> kwin/workspace.cpp e86e39e 
> 
> Diff: http://git.reviewboard.kde.org/r/104344/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bellegarde Cédric
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104344/">http://git.reviewboard.kde.org/r/104344/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 5th, 2012, 2:54 p.m., <b>Aaron J. \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line267" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/style/kcmstyle.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 21)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCMStyle::KCMStyle( QWidget* parent, const QVariantList&amp; )</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">267</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span \
class="p">(</span><span class="n">QLibraryInfo</span><span class="o">::</span><span \
class="n">location</span><span class="p">(</span><span \
class="n">QLibraryInfo</span><span class="o">::</span><span \
class="n">PluginsPath</span><span class="p">)</span> <span class="o">+</span> <span \
class="s">&quot;/menubar/libappmenu-qt.so&quot;</span><span class="p">))</span> <span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">268</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">fineTuningUi</span><span class="p">.</span><span \
class="n">comboMenubarStyle</span><span class="o">-&gt;</span><span \
class="n">hide</span><span class="p">();</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">269</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">fineTuningUi</span><span class="p">.</span><span \
class="n">labelMenubarStyle</span><span class="o">-&gt;</span><span \
class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">&quot;You need to install \
appmenu-qt&quot;</span><span class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">270</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is fine for \
developers, but fairly meaningless for most others. it also means that if a \
distribution decides not to install appmenu-qt for whatever reason, they get a nasty \
little message for their users (reality -&gt; they&#39;ll just patch this out :)

instead, i would suggest hiding the config UI if appmenu-qt is unavailable.</pre>
 </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, will \
fix this.</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 5th, 2012, 2:54 p.m., <b>Aaron J. \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line433" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/style/kcmstyle.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 21)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCMStyle::save()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">433</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="o">&lt;&lt;</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">&quot;You needs to restart applications to make the \
new settings take effect.&quot;</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need, not needs :)

or perhaps:

&quot;Menu bar settings changes will take effect only on application restart.&quot;

this should also be done as a proper notification using KNotify rather than a manual \
dbus call, as that is subject to change (both over time and on different \
platforms)</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to \
use Knotify but it wants me to modify /usr/share/apps/kde/kde.notifyrc from \
kde-runtime. Don&#39;t know why... A way to fix this ?</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 5th, 2012, 2:54 p.m., <b>Aaron J. \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/104344/diff/21/?file=88386#file88386line824" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/style/kcmstyle.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 21)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
KCMStyle::toolbarButtonIndex(const QString &amp;text)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">824</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">configGroup</span> <span class="o">=</span> <span \
class="n">config</span><span class="p">.</span><span class="n">group</span><span \
class="p">(</span><span class="s">&quot;Appmenu Style&quot;</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the kded module seems to \
expect the group to be named &quot;Menubar style&quot; and a config key of \
&quot;MenuBarStyle&quot; .. 

i simply did a kdesrc-build kded-appmenu which pulled the repository from kdereview. \
i confirmed this is the same repo as listed on projects.kde.org .. is this not the \
correct repository, and if not, could you please update it? :)</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
merged kded-appmenu in kde-workspace.git, as asked by Martin.

kded-appmenu.git is the version i maintain for KDE 4.9 users. And so options is the \
one i used in my old patch.

http://quickgit.kde.org/index.php?p=kde-workspace.git&amp;a=commit&amp;h=455dbea1e1775c71e4d6c24431b918c8b4872f91</pre>
 <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 5th, 2012, 2:54 p.m., <b>Aaron J. \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/104344/diff/21/?file=88394#file88394line212" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/clients/oxygen/oxygenclient.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 21)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Oxygen</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">212</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="k">case</span> <span class="nl">MenuButton:</span></pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">212</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">case</span> <span class="nl">MenuButton:</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">213</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="k">return</span> <span class="k">new</span> <span class="n">Button</span><span \
class="p">(</span><span class="o">*</span><span class="k">this</span><span \
class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span \
class="s">&quot;Menu&quot;</span><span class="p">),</span> <span \
class="n">ButtonMenu</span><span class="p">);</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">213</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">return</span> <span class="k">new</span> <span \
class="n">Button</span><span class="p">(</span><span class="o">*</span><span \
class="k">this</span><span class="p">,</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">&quot;<span class="hl">Window \
</span>Menu&quot;</span><span class="p">),</span> <span \
class="n">ButtonMenu</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">214</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">215</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">case</span> <span class="nl">AppMenuButton:</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">216</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">return</span> <span class="k">new</span> <span \
class="n">Button</span><span class="p">(</span><span class="o">*</span><span \
class="k">this</span><span class="p">,</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">&quot;Application Menu&quot;</span><span \
class="p">),</span> <span class="n">ButtonApplicationMenu</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this now appears \
visually a bit reversed:

the application specific menu appears under a generic menu icon and the generic \
window actions appears under the window&#39;s (specific) icons :)

i&#39;d recommend that, at least if App Menu is turned on, the application menu \
appear in the button with the window&#39;s icon.

alternatively, instead of a completely separate button, these 2 buttons could be \
merged into 1, with the window actions menu becoming a submenu (perhaps at the end of \
the menu?) and the app menu populating the rest of the menu.

this limits the # of buttons and resolves the generic/specific icon issue AND as an \
extra special bonus it gives the menu a keyboard shortcut!</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It&#39;s \
not possible, we remove menu drawing from kwin and put it in kded-module...  Kwin \
just do a dbus call: org.kde.kded /modules/appmenu org.kde.kded.showMenu(int x, int \
y, qulonglong WId)

Maybe renaming &quot;Window Menu&quot; to &quot;Window actions&quot; may fix issue \
?</pre> <br />

<p>- Bellegarde</p>

<br />
<p>On October 4th, 2012, 11:27 a.m., Bellegarde Cédric wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Bellegarde Cédric.</div>

<p style="color: grey;"><i>Updated Oct. 4, 2012, 11:27 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here a patch to add appmenu support to kwin via a menu button in \
titlebar

Works by Lionel Chauvin and me, original review request: \
https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

It looks like this:
https://www.youtube.com/watch?v=x1bm7Q6_SH4&amp;hd=1

New version, all drawing code moved to kded-appmenu as asked.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/style/finetuning.ui <span style="color: grey">(2d384bc)</span></li>

 <li>kcontrol/style/kcmstyle.h <span style="color: grey">(cd1472f)</span></li>

 <li>kcontrol/style/kcmstyle.cpp <span style="color: grey">(849a49b)</span></li>

 <li>kwin/CMakeLists.txt <span style="color: grey">(458c341)</span></li>

 <li>kwin/bridge.h <span style="color: grey">(64108e5)</span></li>

 <li>kwin/bridge.cpp <span style="color: grey">(6dbf1bd)</span></li>

 <li>kwin/client.h <span style="color: grey">(130a67a)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(07ffe03)</span></li>

 <li>kwin/clients/oxygen/oxygenbutton.h <span style="color: \
grey">(ea11717)</span></li>

 <li>kwin/clients/oxygen/oxygenbutton.cpp <span style="color: \
grey">(28aa8b1)</span></li>

 <li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(0b39d7d)</span></li>

 <li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(b38b097)</span></li>

 <li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(5502a6a)</span></li>

 <li>kwin/config-kwin.h.cmake <span style="color: grey">(e5ed2a6)</span></li>

 <li>kwin/kcmkwin/kwindecoration/buttons.cpp <span style="color: \
grey">(2d12244)</span></li>

 <li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(52645fd)</span></li>

 <li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(587df7c)</span></li>

 <li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(3fe9fcf)</span></li>

 <li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(e3e884b)</span></li>

 <li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(7b1f3e0)</span></li>

 <li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>

 <li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(b7d0619)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(8fcdba2)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(c4fd281)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(e86e39e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104344/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 