'Review Request: Introduce ui-files for KWin's options configuration'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Introduce ui-files for KWin's options configuration
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-09-24 4:01:05
Message-ID: 20120924040105.29192.68938 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106551/
-----------------------------------------------------------

Review request for kwin and Alexander Jones.

Description
-------

All the tabs of kwinoptions now have a ui file.

In the mouse configurations I dropped the adjustments for left-handed mouse=
, not sure whether it's worth to add that again.

Diffs
-----

  kwin/kcmkwin/kwinoptions/advanced.ui PRE-CREATION =

  kwin/kcmkwin/kwinoptions/actions.ui PRE-CREATION =

  kwin/kcmkwin/kwinoptions/CMakeLists.txt 41a52b77ea7c6078565740cbbc0b6a939=
1785362 =

  kwin/kcmkwin/kwinoptions/focus.ui PRE-CREATION =

  kwin/kcmkwin/kwinoptions/mouse.h f633db2e2da5fdf373420afd8e9f819f4179c601 =

  kwin/kcmkwin/kwinoptions/mouse.cpp 51a80f9d8d1334cfa4456ebf3f3e45d6b62245=
70 =

  kwin/kcmkwin/kwinoptions/mouse.ui PRE-CREATION =

  kwin/kcmkwin/kwinoptions/moving.ui PRE-CREATION =

  kwin/kcmkwin/kwinoptions/windows.h 7bdab6a3eecd4db77ae2c2be7c4aeba3a98917=
25 =

  kwin/kcmkwin/kwinoptions/windows.cpp 100128b00de05db74604c60d9fc0ef8bb452=
5dff =

Diff: http://git.reviewboard.kde.org/r/106551/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106551/">http://git.reviewboard.kde.org/r/106551/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Alexander Jones.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All the tabs of kwinoptions now have a ui file.

In the mouse configurations I dropped the adjustments for left-handed mouse, not sure \
whether it&#39;s worth to add that again.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinoptions/advanced.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwinoptions/actions.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwinoptions/CMakeLists.txt <span style="color: \
grey">(41a52b77ea7c6078565740cbbc0b6a9391785362)</span></li>

 <li>kwin/kcmkwin/kwinoptions/focus.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwinoptions/mouse.h <span style="color: \
grey">(f633db2e2da5fdf373420afd8e9f819f4179c601)</span></li>

 <li>kwin/kcmkwin/kwinoptions/mouse.cpp <span style="color: \
grey">(51a80f9d8d1334cfa4456ebf3f3e45d6b6224570)</span></li>

 <li>kwin/kcmkwin/kwinoptions/mouse.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwinoptions/moving.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(7bdab6a3eecd4db77ae2c2be7c4aeba3a9891725)</span></li>

 <li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(100128b00de05db74604c60d9fc0ef8bb4525dff)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106551/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 