'Re: Review Request: Do not add extra padding to Client::visibleRect()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Do not add extra padding to Client::visibleRect()
From:       "Commit Hook" <null () kde ! org>
Date:       2012-09-19 19:09:24
Message-ID: 20120919190924.11888.63182 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106376/#review19187
-----------------------------------------------------------

This review has been submitted with commit e268b2bea15ab82bb57130e86a518a60=
170396ed by Thomas L=C3=BCbking to branch KDE/4.9.

- Commit Hook

On Sept. 7, 2012, 8:37 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106376/
> -----------------------------------------------------------
> =

> (Updated Sept. 7, 2012, 8:37 p.m.)
> =

> =

> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Hugo Pereira Da Cos=
ta.
> =

> =

> Description
> -------
> =

> This is responsible for the extra padding (and smaller windows) Oxygen de=
corated clients get in https://git.reviewboard.kde.org/r/106336/
> =

> seems to have been introduced by 264d5f4e - do you recall the case behind=
 this? (some plasma dock shadows?) =

> =

> =

> Diffs
> -----
> =

>   kwin/client.h e4d921d =

> =

> Diff: http://git.reviewboard.kde.org/r/106376/diff/
> =

> =

> Testing
> -------
> =

> yes. fixes shrink problem, no shadow artifacts with oxygen deco and docks=
 (tested from Qt assistant) or other apparent issues.
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106376/">http://git.reviewboard.kde.org/r/106376/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e268b2bea15ab82bb57130e86a518a60170396ed by Thomas Lübking to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 7th, 2012, 8:37 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Sept. 7, 2012, 8:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is responsible for the extra padding (and smaller windows) Oxygen \
decorated clients get in https://git.reviewboard.kde.org/r/106336/

seems to have been introduced by 264d5f4e - do you recall the case behind this? (some \
plasma dock shadows?) </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes. fixes shrink problem, no shadow artifacts with oxygen deco and \
docks (tested from Qt assistant) or other apparent issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(e4d921d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106376/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 