'Re: Review Request: Use expandedGeometry to calculate the thumbnail geometry'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use expandedGeometry to calculate the thumbnail geometry
From:       "Commit Hook" <null () kde ! org>
Date:       2012-09-19 19:09:21
Message-ID: 20120919190921.11885.83681 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106336/#review19183
-----------------------------------------------------------

This review has been submitted with commit 66b171f38b1c4bd68ba07e890c2ce1a30e3a5667 \
by Thomas Lübking to branch KDE/4.9.

- Commit Hook

On Sept. 5, 2012, 8:02 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106336/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 8:02 p.m.)
> 
> 
> Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> summarized, see bug.
> 
> nb, that there's either a "bug" in oxygen shadows or the deco-but-not-the-deco \
> code, at least setting the oxygen shadow size to 40 gets me a padding of 80px on \
> either side (this is regardless of this patch), just noticed during testing. 
> However, this leads to smaller windows (than would likely be required) and does \
> (visually) not happen with new shadows. I'll have a look unless Hugo says "no, \
> wait: the UI config is doubled by intent) 
> 
> This addresses bug 301730.
> http://bugs.kde.org/show_bug.cgi?id=301730
> 
> 
> Diffs
> -----
> 
> kwin/scene.cpp 0c5f633 
> 
> Diff: http://git.reviewboard.kde.org/r/106336/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106336/">http://git.reviewboard.kde.org/r/106336/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 66b171f38b1c4bd68ba07e890c2ce1a30e3a5667 by Thomas Lübking to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 5th, 2012, 8:02 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Sept. 5, 2012, 8:02 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized, see bug.

nb, that there&#39;s either a &quot;bug&quot; in oxygen shadows or the \
deco-but-not-the-deco code, at least setting the oxygen shadow size to 40 gets me a \
padding of 80px on either side (this is regardless of this patch), just noticed \
during testing.

However, this leads to smaller windows (than would likely be required) and does \
(visually) not happen with new shadows. I&#39;ll have a look unless Hugo says \
&quot;no, wait: the UI config is doubled by intent) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=301730">301730</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene.cpp <span style="color: grey">(0c5f633)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106336/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 