'Re: Review Request: Use KConfigXT in ThumbnailAside effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use KConfigXT in ThumbnailAside effect
From:       "Commit Hook" <null () kde ! org>
Date:       2012-09-19 8:32:31
Message-ID: 20120919083231.4333.25180 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106436/#review19145
-----------------------------------------------------------

This review has been submitted with commit cb917d74be43b7071e691f27c6ac3ac9=
693aeca5 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Sept. 13, 2012, 6:31 a.m., Andrea Scarpino wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106436/
> -----------------------------------------------------------
> =

> (Updated Sept. 13, 2012, 6:31 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Use KConfigXT in ThumbnailAside effect
> =

> =

> Diffs
> -----
> =

>   kwin/effects/thumbnailaside/thumbnailasideconfig.kcfgc PRE-CREATION =

>   kwin/effects/thumbnailaside/CMakeLists.txt ac14c85 =

>   kwin/effects/thumbnailaside/thumbnailaside.cpp fb8e7c3 =

>   kwin/effects/thumbnailaside/thumbnailaside.kcfg PRE-CREATION =

>   kwin/effects/thumbnailaside/thumbnailaside_config.h 9e59a27 =

>   kwin/effects/thumbnailaside/thumbnailaside_config.cpp ce70078 =

>   kwin/effects/thumbnailaside/thumbnailaside_config.ui 8821b3a =

> =

> Diff: http://git.reviewboard.kde.org/r/106436/diff/
> =

> =

> Testing
> -------
> =

> I get this error on linking:
> =

> CMakeFiles/kcm_kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside_co=
nfig.o: In function `KWin::ThumbnailAsideEffectConfig::ThumbnailAsideEffect=
Config(QWidget*, QList<QVariant> const&)':
> thumbnailaside_config.cpp:(.text+0x2ee): undefined reference to `KWin::Th=
umbnailAsideConfig::self()'
> collect2: error: ld returned 1 exit status
> =

> =

> Thanks,
> =

> Andrea Scarpino
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106436/">http://git.reviewboard.kde.org/r/106436/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cb917d74be43b7071e691f27c6ac3ac9693aeca5 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 13th, 2012, 6:31 a.m., Andrea Scarpino wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Andrea Scarpino.</div>

<p style="color: grey;"><i>Updated Sept. 13, 2012, 6:31 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KConfigXT in ThumbnailAside effect</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I get this error on linking:

CMakeFiles/kcm_kwin4_effect_builtins.dir/thumbnailaside/thumbnailaside_config.o: In \
function `KWin::ThumbnailAsideEffectConfig::ThumbnailAsideEffectConfig(QWidget*, \
QList&lt;QVariant&gt; const&amp;)&#39;: thumbnailaside_config.cpp:(.text+0x2ee): \
                undefined reference to `KWin::ThumbnailAsideConfig::self()&#39;
collect2: error: ld returned 1 exit status</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/thumbnailaside/thumbnailasideconfig.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/thumbnailaside/CMakeLists.txt <span style="color: \
grey">(ac14c85)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside.cpp <span style="color: \
grey">(fb8e7c3)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside_config.h <span style="color: \
grey">(9e59a27)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside_config.cpp <span style="color: \
grey">(ce70078)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside_config.ui <span style="color: \
grey">(8821b3a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106436/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 