[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add screen rule
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-09-16 19:53:18
Message-ID: 20120916195318.12227.77814 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106167/#review19037
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gräßlin
On Aug. 24, 2012, 4:53 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106167/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2012, 4:53 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> requested (indirectly, usually misconception the gone xinerama setting) couple of \
> times
> the screen rule is free (up to 99) - if the ruled screen is larger than the screen \
> amount, the rule is ignored (you can move the window on all screens) but i assume \
> the most relevant part is "apply initially"
>
> This addresses bug 183996.
> http://bugs.kde.org/show_bug.cgi?id=183996
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 0ff1abd
> kwin/kcmkwin/kwinrules/ruleswidget.cpp 5c1ee92
> kwin/geometry.cpp edca219
> kwin/kcmkwin/kwinrules/ruleswidget.h 27cf731
> kwin/manage.cpp 4b3ec7c
> kwin/rules.h bf299f0
> kwin/rules.cpp 5b94e76
> kwin/workspace.cpp cf3f308
>
> Diff: http://git.reviewboard.kde.org/r/106167/diff/
>
>
> Testing
> -------
>
> Yes
> - Except "remember"
> - it's still possible to quicktile the window on the wrong screen (quicktiling \
> however also breaks other restrictions atm)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106167/">http://git.reviewboard.kde.org/r/106167/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Martin</p>
<br />
<p>On August 24th, 2012, 4:53 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2012, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">requested (indirectly, usually misconception the gone xinerama setting) \
couple of times
the screen rule is free (up to 99) - if the ruled screen is larger than the screen \
amount, the rule is ignored (you can move the window on all screens) but i assume the \
most relevant part is "apply initially"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes
- Except "remember"
- it's still possible to quicktile the window on the wrong screen (quicktiling \
however also breaks other restrictions atm)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183996">183996</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwinrules/ruleswidgetbase.ui <span style="color: \
grey">(0ff1abd)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(5c1ee92)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(edca219)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(27cf731)</span></li>
<li>kwin/manage.cpp <span style="color: grey">(4b3ec7c)</span></li>
<li>kwin/rules.h <span style="color: grey">(bf299f0)</span></li>
<li>kwin/rules.cpp <span style="color: grey">(5b94e76)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(cf3f308)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106167/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic