[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: KWin Idea "Use KWin::Options in KCMs"
From: "makis marimpis" <makhsm () gmail ! com>
Date: 2012-09-06 7:34:10
Message-ID: 20120906073410.15999.88867 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104955/
-----------------------------------------------------------
(Updated Sept. 6, 2012, 7:34 a.m.)
Review request for kwin.
Changes
-------
Resolved the issues, except the ones about saving/loading and the macro Thomas \
suggested.
I cannot compile it for the time being, including "options.h" breaks with:
In file included from \
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/../../options.h:32:0,
from \
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/main.cpp:50:
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/../../utils.h:47:1: error: \
redefinition of ‘struct QMetaTypeId<QList<int> >'
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/interface_util.h:25:1: error: \
previous definition of ‘struct QMetaTypeId<QList<int> >'
Tried a couple of tricks but i didn't manage to continue with the compilation :/
Description
-------
Hello, i picked up the "Use KWin::Options in KCMs" idea from the wiki.
I managed to match most of the options, except those (if any) in file "mouse.cpp" :/
Diffs (updated)
-----
kwin/kcmkwin/kwincompositing/main.cpp 7a89db49fa9cc958a3debe221a1d9a5e6fb68075
kwin/kcmkwin/kwinoptions/windows.h 7bdab6a3eecd4db77ae2c2be7c4aeba3a9891725
kwin/kcmkwin/kwinoptions/windows.cpp 100128b00de05db74604c60d9fc0ef8bb4525dff
kwin/kcmkwin/kwinscreenedges/main.cpp 2f463c7d7ca1cbf964bd4327b9e5f7cf444edca8
Diff: http://git.reviewboard.kde.org/r/104955/diff/
Testing
-------
Yes
Thanks,
makis marimpis
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104955/">http://git.reviewboard.kde.org/r/104955/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2012, 7:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Resolved the issues, except the ones about saving/loading and the macro \
Thomas suggested.
I cannot compile it for the time being, including "options.h" breaks with:
In file included from \
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/../../options.h:32:0,
from \
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/main.cpp:50:
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/../../utils.h:47:1: error: \
redefinition of ‘struct QMetaTypeId<QList<int> >'
..../kde-workspace-live/kwin/kcmkwin/kwincompositing/interface_util.h:25:1: error: \
previous definition of ‘struct QMetaTypeId<QList<int> >'
Tried a couple of tricks but i didn't manage to continue with the compilation \
:/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello, i picked up the "Use KWin::Options in KCMs" idea from \
the wiki. I managed to match most of the options, except those (if any) in file \
"mouse.cpp" :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(7a89db49fa9cc958a3debe221a1d9a5e6fb68075)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(7bdab6a3eecd4db77ae2c2be7c4aeba3a9891725)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(100128b00de05db74604c60d9fc0ef8bb4525dff)</span></li>
<li>kwin/kcmkwin/kwinscreenedges/main.cpp <span style="color: \
grey">(2f463c7d7ca1cbf964bd4327b9e5f7cf444edca8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104955/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic