--===============3108516299168037026== Content-Type: multipart/alternative; boundary="===============7003325550906362617==" --===============7003325550906362617== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104344/ ----------------------------------------------------------- (Updated Aug. 31, 2012, 1:45 p.m.) Review request for kwin. Changes ------- - Move menu availability cache to client as kcommondecoration is destroyed = on button re-positioning - Add support for showRequest kded-appmenu signal for better menu placement= when menu requested by application Description ------- Here a patch to add appmenu support to kwin via a menu button in titlebar Works by Lionel Chauvin and me, original review request: https://git.review= board.kde.org/r/101162/ It depends on: http://quickgit.kde.org/index.php?p=3Dkded-appmenu.git It looks like this: https://www.youtube.com/watch?v=3Dx1bm7Q6_SH4&hd=3D1 New version, all drawing code moved to kded-appmenu as asked. Diffs (updated) ----- kwin/kcmkwin/kwindecoration/preview.h 52645fd = kwin/kcmkwin/kwindecoration/preview.cpp 587df7c = kwin/libkdecorations/kcommondecoration.h 3fe9fcf = kwin/libkdecorations/kcommondecoration.cpp 13a4c49 = kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244 = kwin/clients/oxygen/oxygenbutton.h ea11717 = kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1 = kwin/clients/oxygen/oxygenclient.h 98e60cc = kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb = kwin/clients/oxygen/oxygenfactory.h b38b097 = kwin/clients/oxygen/oxygenfactory.cpp 5502a6a = kwin/config-kwin.h.cmake e5ed2a6 = kcontrol/style/kcmstyle.h cd1472f = kcontrol/style/kcmstyle.cpp 849a49b = kwin/CMakeLists.txt ce69e84 = kwin/bridge.h 64108e5 = kwin/bridge.cpp 32d4c84 = kwin/client.h f31707b = kwin/client.cpp c541595 = kcontrol/style/finetuning.ui 2d384bc = kwin/libkdecorations/kdecoration.h 614b902 = kwin/libkdecorations/kdecoration.cpp 71f4f8d = kwin/libkdecorations/kdecorationbridge.h b7d0619 = kwin/workspace.h 16630f7 = kwin/workspace.cpp cf3f308 = Diff: http://git.reviewboard.kde.org/r/104344/diff/ Testing ------- Thanks, Bellegarde C=C3=A9dric --===============7003325550906362617== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104344/

Review request for kwin.
By Bellegarde C=C3=A9dric.

Updated Aug. 31, 2012, 1:45 p.m.

Changes 
- Move menu availability cache to client as kcommondecoratio=
n is destroyed on button re-positioning
- Add support for showRequest kded-appmenu signal for better menu placement=
 when menu requested by application

Descripti= on 

Here a patch to add appmenu support to kwin via a menu butto=
n in titlebar

Works by Lionel Chauvin and me, original review request: https://git.review=
board.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=3Dkded-appmenu.git

It looks like this:
https://www.youtube.com/watch?v=3Dx1bm7Q6_SH4&hd=3D1

New version, all drawing code moved to kded-appmenu as asked.

Diffs= (updated)

  • kwin/kcmkwin/kwindecoration/preview.h (526= 45fd)
  • kwin/kcmkwin/kwindecoration/preview.cpp (5= 87df7c)
  • kwin/libkdecorations/kcommondecoration.h (= 3fe9fcf)
  • kwin/libkdecorations/kcommondecoration.cpp (13a4c49)
  • kwin/kcmkwin/kwindecoration/buttons.cpp (2= d12244)
  • kwin/clients/oxygen/oxygenbutton.h (ea1171= 7)
  • kwin/clients/oxygen/oxygenbutton.cpp (28aa= 8b1)
  • kwin/clients/oxygen/oxygenclient.h (98e60c= c)
  • kwin/clients/oxygen/oxygenclient.cpp (5fbb= 4fb)
  • kwin/clients/oxygen/oxygenfactory.h (b38b0= 97)
  • kwin/clients/oxygen/oxygenfactory.cpp (550= 2a6a)
  • kwin/config-kwin.h.cmake (e5ed2a6)<= /li>
  • kcontrol/style/kcmstyle.h (cd1472f)=
  • kcontrol/style/kcmstyle.cpp (849a49b)
  • kwin/CMakeLists.txt (ce69e84)
  • kwin/bridge.h (64108e5)
  • kwin/bridge.cpp (32d4c84)
  • kwin/client.h (f31707b)
  • kwin/client.cpp (c541595)
  • kcontrol/style/finetuning.ui (2d384bc)
  • kwin/libkdecorations/kdecoration.h (614b90= 2)
  • kwin/libkdecorations/kdecoration.cpp (71f4= f8d)
  • kwin/libkdecorations/kdecorationbridge.h (= b7d0619)
  • kwin/workspace.h (16630f7)
  • kwin/workspace.cpp (cf3f308)

View Diff
--===============7003325550906362617==-- --===============3108516299168037026== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3108516299168037026==--