'Re: Review Request: Remove superfluous Compositor checks in events.cpp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Remove superfluous Compositor checks in events.cpp
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-08-30 9:23:54
Message-ID: 20120830092354.29608.52522 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106255/
-----------------------------------------------------------

(Updated Aug. 30, 2012, 9:23 a.m.)

Review request for kwin.

Changes
-------

* changed in PaintRedirector from Workspace to Compositor to check for comp=
ositing

Summary (updated)
-----------------

Remove superfluous Compositor checks in events.cpp

Description
-------

Remove superfluous Compositor checks in events.cpp

compositing() ensures that m_compositor is not null.

Make the Compositor a proper Singleton

The Compositor class actually behaves like a Singleton so it should be
one. Therefore three static methods are added:
* self() to access the Singleton
* createCompositor() to be used by Workspace to create the instance
* isCreated() to have a simple check whether the Singleton is already
  created

The isCreated() check is actually required as especially Clients might
be created and trying to access the Compositor before it is setup.

Diffs (updated)
-----

  kwin/bridge.cpp 670063e2276a506e0b3f3e29d2fef3b946032f82 =

  kwin/client.cpp 569494418117f3b987f05c844debac48a88ed05d =

  kwin/composite.h a4a37107ffe4981e9758c9ff65779c646ae94ffb =

  kwin/composite.cpp 640ebd6a3c09e82492d79b9b2d68d752d6a0c62c =

  kwin/events.cpp 23e1921bfa653fcf399378c0328733fb996b9d1f =

  kwin/geometry.cpp 19a911d097c3fd87da28ede9dc9fd362310146cc =

  kwin/paintredirector.cpp 55b20c4f4eae2723df46e92654c851e912cd5008 =

  kwin/workspace.h 3f4bd9f93a27c832fef913e5fdbcc24518fadb4d =

  kwin/workspace.cpp e03e5e765bea8d098bd86dd5118198ddccd8fd8d =

Diff: http://git.reviewboard.kde.org/r/106255/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106255/">http://git.reviewboard.kde.org/r/106255/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 30, 2012, 9:23 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* changed in PaintRedirector from Workspace to Compositor to check for \
compositing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove superfluous Compositor checks in events.cpp</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove superfluous Compositor checks in events.cpp

compositing() ensures that m_compositor is not null.

Make the Compositor a proper Singleton

The Compositor class actually behaves like a Singleton so it should be
one. Therefore three static methods are added:
* self() to access the Singleton
* createCompositor() to be used by Workspace to create the instance
* isCreated() to have a simple check whether the Singleton is already
  created

The isCreated() check is actually required as especially Clients might
be created and trying to access the Compositor before it is setup.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/bridge.cpp <span style="color: \
grey">(670063e2276a506e0b3f3e29d2fef3b946032f82)</span></li>

 <li>kwin/client.cpp <span style="color: \
grey">(569494418117f3b987f05c844debac48a88ed05d)</span></li>

 <li>kwin/composite.h <span style="color: \
grey">(a4a37107ffe4981e9758c9ff65779c646ae94ffb)</span></li>

 <li>kwin/composite.cpp <span style="color: \
grey">(640ebd6a3c09e82492d79b9b2d68d752d6a0c62c)</span></li>

 <li>kwin/events.cpp <span style="color: \
grey">(23e1921bfa653fcf399378c0328733fb996b9d1f)</span></li>

 <li>kwin/geometry.cpp <span style="color: \
grey">(19a911d097c3fd87da28ede9dc9fd362310146cc)</span></li>

 <li>kwin/paintredirector.cpp <span style="color: \
grey">(55b20c4f4eae2723df46e92654c851e912cd5008)</span></li>

 <li>kwin/workspace.h <span style="color: \
grey">(3f4bd9f93a27c832fef913e5fdbcc24518fadb4d)</span></li>

 <li>kwin/workspace.cpp <span style="color: \
grey">(e03e5e765bea8d098bd86dd5118198ddccd8fd8d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106255/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 