From kwin Tue Aug 28 19:51:42 2012 From: "Commit Hook" Date: Tue, 28 Aug 2012 19:51:42 +0000 To: kwin Subject: Re: Review Request: Ensure main.qml presence in decoration kcm Message-Id: <20120828195142.3719.5936 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=134618352514831 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3957391809330386867==" --===============3957391809330386867== Content-Type: multipart/alternative; boundary="===============3566354718766095219==" --===============3566354718766095219== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106062/#review18192 ----------------------------------------------------------- This review has been submitted with commit 6acbd605bd28186f71bede467a518388= 1ca82fe9 by Thomas L=C3=BCbking to branch master. - Commit Hook On Aug. 18, 2012, 10:11 a.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106062/ > ----------------------------------------------------------- > = > (Updated Aug. 18, 2012, 10:11 a.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > This handles it gracefully. > Given the kcm is usually in and will crash systemsettings i've a slight t= endency towards this but would also be fine with an assert (or straight abo= rt regardless of compile mode) > = > Ratio: > The code relies on the presence of an extern resource and produces "funny= " crashes if absent - that somebody has to investigate. > = > I also propose to check kwin for similar hard deps on extern resources an= d handle them in a common way. > = > = > This addresses bug 304881. > http://bugs.kde.org/show_bug.cgi?id=3D304881 > = > = > Diffs > ----- > = > kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209 = > = > Diff: http://git.reviewboard.kde.org/r/106062/diff/ > = > = > Testing > ------- > = > Yes, deleted main.qml -> crash. > W/ patch I get an ugly label telling me that i shall contact my distro be= cause an important file is missing. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============3566354718766095219== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106062/ 

This revie=
w has been submitted with commit 6acbd605bd28186f71bede467a5183881ca82fe9 b=
y Thomas L=C3=BCbking to branch master.

- Commit


On August 18th, 2012, 10:11 a.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Aug. 18, 2012, 10:11 a.m.

Descripti= on 

This handles it gracefully.
Given the kcm is usually in and will crash systemsettings i've a slight=
 tendency towards this but would also be fine with an assert (or straight a=
bort regardless of compile mode)

Ratio:
The code relies on the presence of an extern resource and produces "fu=
nny" crashes if absent - that somebody has to investigate.

I also propose to check kwin for similar hard deps on extern resources and =
handle them in a common way.

Testing <= /h1> 
Yes, deleted main.qml -> crash.
W/ patch I get an ugly label telling me that i shall contact my distro beca=
use an important file is missing.
Bugs: 304881

Diffs=

  • kwin/kcmkwin/kwindecoration/kwindecoration.cpp (1f7a209)

View Diff
--===============3566354718766095219==-- --===============3957391809330386867== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3957391809330386867==--