--===============2898524250405614207== Content-Type: multipart/alternative; boundary="===============5320383137016843982==" --===============5320383137016843982== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106182/#review18188 ----------------------------------------------------------- This review has been submitted with commit 9191c58f3d235270c56829e2f4f641fb= 203d3b35 by Thomas L=C3=BCbking to branch master. - Commit Hook On Aug. 28, 2012, 4:44 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106182/ > ----------------------------------------------------------- > = > (Updated Aug. 28, 2012, 4:44 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > is broken (clients always end up in the same position because of checkWor= kspacePosition() and the recursion - also when tabbing out of a maximized c= lient, things become tricky, because the suggested geometry will be the max= imized one) and i "fixed" that bug btw. > = > = > This addresses bug 226881. > http://bugs.kde.org/show_bug.cgi?id=3D226881 > = > = > Diffs > ----- > = > kwin/client.cpp 09b0328 = > kwin/placement.cpp f091d9d = > kwin/tabgroup.h 3ad0a08 = > kwin/tabgroup.cpp 771d789 = > kwin/useractions.cpp deb6507 = > kwin/workspace.h 1fa0c20 = > = > Diff: http://git.reviewboard.kde.org/r/106182/diff/ > = > = > Testing > ------- > = > why was this deleted? > = > yes - tabbed out of normal, max'd and QT'd windows with pointer DnD and c= ontext menu action > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============5320383137016843982== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106182/ 

This revie=
w has been submitted with commit 9191c58f3d235270c56829e2f4f641fb203d3b35 b=
y Thomas L=C3=BCbking to branch master.

- Commit


On August 28th, 2012, 4:44 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Aug. 28, 2012, 4:44 p.m.

Descripti= on 

is broken (clients always end up in the same position becaus=
e of checkWorkspacePosition() and the recursion - also when tabbing out of =
a maximized client, things become tricky, because the suggested geometry wi=
ll be the maximized one) and i "fixed" that bug btw.

Testing <= /h1> 
why was this deleted?

yes - tabbed out of normal, max'd and QT'd windows with pointer DnD=
 and context menu action
Bugs: 226881

Diffs=

  • kwin/client.cpp (09b0328)
  • kwin/placement.cpp (f091d9d)
  • kwin/tabgroup.h (3ad0a08)
  • kwin/tabgroup.cpp (771d789)
  • kwin/useractions.cpp (deb6507)
  • kwin/workspace.h (1fa0c20)

View Diff
--===============5320383137016843982==-- --===============2898524250405614207== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2898524250405614207==--