From kwin Tue Aug 28 19:51:31 2012 From: "Commit Hook" Date: Tue, 28 Aug 2012 19:51:31 +0000 To: kwin Subject: Re: Review Request: delay unsynced showing by at max 50ms Message-Id: <20120828195131.3704.25305 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=134618351814823 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3663454976691485169==" --===============3663454976691485169== Content-Type: multipart/alternative; boundary="===============8285145976291653837==" --===============8285145976291653837== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106173/#review18187 ----------------------------------------------------------- This review has been submitted with commit e617f176d1e293abcaafbb14d0afcf8a= ee24f054 by Thomas L=C3=BCbking to branch master. - Commit Hook On Aug. 24, 2012, 9:08 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106173/ > ----------------------------------------------------------- > = > (Updated Aug. 24, 2012, 9:08 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > to workaround that bug / issue > The very first damage event will still cause a full repaint (with setRead= yForPainting) > = > = > This addresses bug 295254. > http://bugs.kde.org/show_bug.cgi?id=3D295254 > = > = > Diffs > ----- > = > kwin/client.cpp 09b0328 = > kwin/composite.cpp 12bb75a = > kwin/effects.h 014c4cf = > kwin/effects.cpp f3fd7e5 = > kwin/toplevel.h aba9321 = > kwin/toplevel.cpp 9417813 = > kwin/unmanaged.h b11d62b = > = > Diff: http://git.reviewboard.kde.org/r/106173/diff/ > = > = > Testing > ------- > = > gimp testcase i mentioned in the bug. works. > Also even with a significant test delay (250ms) the windows still nearly = map immediately (for the initial damage event) > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============8285145976291653837== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106173/ 

This revie=
w has been submitted with commit e617f176d1e293abcaafbb14d0afcf8aee24f054 b=
y Thomas L=C3=BCbking to branch master.

- Commit


On August 24th, 2012, 9:08 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Aug. 24, 2012, 9:08 p.m.

Descripti= on 

to workaround that bug / issue
The very first damage event will still cause a full repaint (with setReadyF=
orPainting)

Testing <= /h1> 
gimp testcase i mentioned in the bug. works.
Also even with a significant test delay (250ms) the windows still nearly ma=
p immediately (for the initial damage event)
Bugs: 295254

Diffs=

  • kwin/client.cpp (09b0328)
  • kwin/composite.cpp (12bb75a)
  • kwin/effects.h (014c4cf)
  • kwin/effects.cpp (f3fd7e5)
  • kwin/toplevel.h (aba9321)
  • kwin/toplevel.cpp (9417813)
  • kwin/unmanaged.h (b11d62b)

View Diff
--===============8285145976291653837==-- --===============3663454976691485169== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3663454976691485169==--