This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106060/

On August 27th, 2012, 1:41 p.m., Thomas L= =C3=BCbking wrote:
= = =
kwin/events.cpp (Diff revision 3)
bool Workspace::workspaceEvent(XEvent * e)
462
            if (compositing(=
)) {
470
            if (compositing(=
) &am=
p;& m_compositor) {
the "=
;&& m_compositor" is superfluous?
On August 27th, 2012, 7:14 p.m., Martin Gr=C3=A4=C3=9Flin wrote:=
a left ov=
er from the time when compositing() did not yet check for compositor

kwin/events.cpp (Diff revision 3)
bool Workspace::workspaceEvent(XEvent * e)
462	if (compositing(= )) {	470	if (compositing(= ) &am= p;& m_compositor) {

created a new Review Request for the Singleton and the cleanup of ev=
ents: http://git.reviewboard.kde.org/r/106255/

- Martin

On August 23rd, 2012, 12:50 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin and Arthur Arlt.

By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 23, 2012, 12:50 p.m.

Descripti= on

Based on review request 102420 which got rebased on current =
master. In addition some further work has been added by me:
* renamed a few methods and variables, by dropping compositing prefixes
* made the Scene a private member of the Compositor class. Outside the comp=
ositor it has only been used to determine whether Compositing is active.
* moved reinitCompositing and restartKWin from Workspace to Compositor

Further planned work once this is in master:
* better way to determine whether Compositing is active (currently no longe=
r an inline method)
* export /Compositor on D-Bus interface
* deprecate the Compositing related D-Bus methods in the Workspace interface
* maybe make EffectsHandlerImpl a private member of Compositor

Testing <= /h1>

currently running and have not noticed any problems except K=
Win crashes on Shutdown. Will investigate once I see the proper highlighted=
 diff in the interface

Diffs=

kwin/activation.cpp (7c07d5e)
kwin/bridge.cpp (32d4c84)
kwin/client.h (f31707b)
kwin/client.cpp (c541595)
kwin/composite.h (PRE-CREATION)
kwin/composite.cpp (c65716b)
kwin/effects.h (014c4cf)
kwin/effects.cpp (9986691)
kwin/events.cpp (6856922)
kwin/geometry.cpp (edca219)
kwin/layers.cpp (4521554)
kwin/paintredirector.cpp (7ed4d6f)<= /li>
kwin/scene.h (3891198)
kwin/scene.cpp (5782510)
kwin/scene_opengl.h (de33ce4)
kwin/scene_opengl.cpp (cbcc0ca)
kwin/toplevel.h (aba9321)
kwin/toplevel.cpp (9417813)
kwin/utils.h (9eb3589)
kwin/workspace.h (16630f7)
kwin/workspace.cpp (cf3f308)

View Diff

Descripti= on

Testing <= /h1> currently running and have not noticed any problems except K= Win crashes on Shutdown. Will investigate once I see the proper highlighted= diff in the interface

Diffs=

Testing <= /h1>

currently running and have not noticed any problems except K= Win crashes on Shutdown. Will investigate once I see the proper highlighted= diff in the interface