On August 27th, 2012, 1:41 p.m., Thomas Lübking wrote:
|
kwin/events.cpp
(Diff revision 3)
|
bool Workspace::workspaceEvent(XEvent * e) |
| 462 |
if (compositing()) { |
470 |
if (compositing() && m_compositor) { |
the "&& m_compositor" is superfluous?
On August 27th, 2012, 7:14 p.m., Martin Gräßlin wrote:
a left over from the time when compositing() did not yet check for compositor
created a new Review Request for the Singleton and the cleanup of events: http://git.reviewboard.kde.org/r/106255/
- Martin
On August 23rd, 2012, 12:50 p.m., Martin Gräßlin wrote:
|
Review request for kwin and Arthur Arlt.
By Martin Gräßlin.
Updated Aug. 23, 2012, 12:50 p.m.
Description
Based on review request 102420 which got rebased on current master. In addition some further work has been added by me:
* renamed a few methods and variables, by dropping compositing prefixes
* made the Scene a private member of the Compositor class. Outside the compositor it has only been used to determine whether Compositing is active.
* moved reinitCompositing and restartKWin from Workspace to Compositor
Further planned work once this is in master:
* better way to determine whether Compositing is active (currently no longer an inline method)
* export /Compositor on D-Bus interface
* deprecate the Compositing related D-Bus methods in the Workspace interface
* maybe make EffectsHandlerImpl a private member of Compositor
|
Testing
currently running and have not noticed any problems except KWin crashes on Shutdown. Will investigate once I see the proper highlighted diff in the interface
|
Diffs
- kwin/activation.cpp (7c07d5e)
- kwin/bridge.cpp (32d4c84)
- kwin/client.h (f31707b)
- kwin/client.cpp (c541595)
- kwin/composite.h (PRE-CREATION)
- kwin/composite.cpp (c65716b)
- kwin/effects.h (014c4cf)
- kwin/effects.cpp (9986691)
- kwin/events.cpp (6856922)
- kwin/geometry.cpp (edca219)
- kwin/layers.cpp (4521554)
- kwin/paintredirector.cpp (7ed4d6f)
- kwin/scene.h (3891198)
- kwin/scene.cpp (5782510)
- kwin/scene_opengl.h (de33ce4)
- kwin/scene_opengl.cpp (cbcc0ca)
- kwin/toplevel.h (aba9321)
- kwin/toplevel.cpp (9417813)
- kwin/utils.h (9eb3589)
- kwin/workspace.h (16630f7)
- kwin/workspace.cpp (cf3f308)
View Diff
|