'Review Request: o not show the menu if the button is down for the second click'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: o not show the menu if the button is down for the second click
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-08-26 21:25:16
Message-ID: 20120826212516.908.60557 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106227/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

if one clicks very fast, the timeout will coincident with the second downtime \
(between press and release) what was used to be interpreted as "still down"

This addresses bug 305738.
    http://bugs.kde.org/show_bug.cgi?id=305738

Diffs
-----

  kwin/libkdecorations/kcommondecoration.cpp 13a4c49 

Diff: http://git.reviewboard.kde.org/r/106227/diff/

Testing
-------

i'm no more the gamer i was (fuck, i got old) but i could cause the issue (many times \
for inspection) and while it was late, i didn't manage to trigger it right after the \
patch. So I guess that's it (also it of course makes sense and i understood why it \
would fail, but who cares about such stuff)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106227/">http://git.reviewboard.kde.org/r/106227/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if one clicks very fast, the timeout will coincident with the second \
downtime (between press and release) what was used to be interpreted as &quot;still \
down&quot; </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i&#39;m no more the gamer i was (fuck, i got old) but i could cause the \
issue (many times for inspection) and while it was late, i didn&#39;t manage to \
trigger it right after the patch. So I guess that&#39;s it (also it of course makes \
sense and i understood why it would fail, but who cares about such stuff)</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=305738">305738</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(13a4c49)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106227/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 