This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105768/ 

This review has been submitted with commit 11325bf8f643339bb83a9f8ebcb706e03332ff72 by Martin Gräßlin to branch master.

- Commit


On August 25th, 2012, 9:15 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 25, 2012, 9:15 a.m.

Description 

This is the other part to the review request for QML support in Aurorae. The buttons are a little bit of cheating as they are rendered in C++ through an extension plugin.

Currently there are a few regressions compared to the native variant:
* colored border option is not supported, I'm not really sure what it actually does
* explicit button spacer is too small
* corners are not yet rounded

Diffs

  • kwin/clients/aurorae/CMakeLists.txt (f5eeb71)
  • kwin/clients/aurorae/src/CMakeLists.txt (71be39a)
  • kwin/clients/aurorae/src/aurorae.h (fabd828)
  • kwin/clients/aurorae/src/aurorae.cpp (4277b65)
  • kwin/clients/aurorae/src/colorhelper.h (PRE-CREATION)
  • kwin/clients/aurorae/src/colorhelper.cpp (PRE-CREATION)
  • kwin/clients/aurorae/src/decorationoptions.h (PRE-CREATION)
  • kwin/clients/aurorae/src/decorationoptions.cpp (PRE-CREATION)
  • kwin/clients/aurorae/src/decorationplugin.h (PRE-CREATION)
  • kwin/clients/aurorae/src/decorationplugin.cpp (PRE-CREATION)
  • kwin/clients/aurorae/src/kwindecoration.desktop (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/ButtonGroup.qml (PRE-CREATION)
  • kwin/clients/aurorae/src/qml/MenuButton.qml (e2f67ec)
  • kwin/clients/aurorae/src/qml/aurorae.qml (acd6d7a)
  • kwin/clients/aurorae/src/qml/qmldir (PRE-CREATION)
  • kwin/clients/aurorae/themes/CMakeLists.txt (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/CMakeLists.txt (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/plastikbutton.h (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/plastikplugin.h (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/code/qmldir (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/package/contents/config/main.xml (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/package/contents/ui/config.ui (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (PRE-CREATION)
  • kwin/clients/aurorae/themes/plastik/package/metadata.desktop (PRE-CREATION)
  • kwin/kcmkwin/kwindecoration/CMakeLists.txt (da02993)
  • kwin/kcmkwin/kwindecoration/auroraeconfig.ui (7762140)
  • kwin/kcmkwin/kwindecoration/decorationmodel.h (0a5a116)
  • kwin/kcmkwin/kwindecoration/decorationmodel.cpp (4915d10)
  • kwin/kcmkwin/kwindecoration/kwindecoration.cpp (1f7a209)
  • kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml (8db4065)
  • kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml (PRE-CREATION)
  • kwin/kcmkwin/kwindecoration/qml/main.qml (9ca0e89)

View Diff

Screenshots

Old and new Plastik