From kwin  Sun Aug 26 19:00:17 2012
From: "Commit Hook" <null () kde ! org>
Date: Sun, 26 Aug 2012 19:00:17 +0000
To: kwin
Subject: Re: Review Request: Port of Plastik to QML
Message-Id: <20120826190017.20790.99742 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kwin&m=134600764828345
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============7674937747920057903=="

--===============7674937747920057903==
Content-Type: multipart/alternative;
	boundary="===============1207995244355305637=="

--===============1207995244355305637==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105768/#review18049
-----------------------------------------------------------


This review has been submitted with commit 11325bf8f643339bb83a9f8ebcb706e0=
3332ff72 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook


On Aug. 25, 2012, 9:15 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105768/
> -----------------------------------------------------------
> =

> (Updated Aug. 25, 2012, 9:15 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> This is the other part to the review request for QML support in Aurorae. =
The buttons are a little bit of cheating as they are rendered in C++ throug=
h an extension plugin.
> =

> Currently there are a few regressions compared to the native variant:
> * colored border option is not supported, I'm not really sure what it act=
ually does
> * explicit button spacer is too small
> * corners are not yet rounded
> =

> =

> Diffs
> -----
> =

>   kwin/clients/aurorae/CMakeLists.txt f5eeb71 =

>   kwin/clients/aurorae/src/CMakeLists.txt 71be39a =

>   kwin/clients/aurorae/src/aurorae.h fabd828 =

>   kwin/clients/aurorae/src/aurorae.cpp 4277b65 =

>   kwin/clients/aurorae/src/colorhelper.h PRE-CREATION =

>   kwin/clients/aurorae/src/colorhelper.cpp PRE-CREATION =

>   kwin/clients/aurorae/src/decorationoptions.h PRE-CREATION =

>   kwin/clients/aurorae/src/decorationoptions.cpp PRE-CREATION =

>   kwin/clients/aurorae/src/decorationplugin.h PRE-CREATION =

>   kwin/clients/aurorae/src/decorationplugin.cpp PRE-CREATION =

>   kwin/clients/aurorae/src/kwindecoration.desktop PRE-CREATION =

>   kwin/clients/aurorae/src/qml/ButtonGroup.qml PRE-CREATION =

>   kwin/clients/aurorae/src/qml/MenuButton.qml e2f67ec =

>   kwin/clients/aurorae/src/qml/aurorae.qml acd6d7a =

>   kwin/clients/aurorae/src/qml/qmldir PRE-CREATION =

>   kwin/clients/aurorae/themes/CMakeLists.txt PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/CMakeLists.txt PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/plastikbutton.h PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/plastikplugin.h PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/code/qmldir PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/package/contents/config/main.xml PR=
E-CREATION =

>   kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.q=
ml PRE-CREATION =

>   kwin/clients/aurorae/themes/plastik/package/contents/ui/config.ui PRE-C=
REATION =

>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml PRE-CR=
EATION =

>   kwin/clients/aurorae/themes/plastik/package/metadata.desktop PRE-CREATI=
ON =

>   kwin/kcmkwin/kwindecoration/CMakeLists.txt da02993 =

>   kwin/kcmkwin/kwindecoration/auroraeconfig.ui 7762140 =

>   kwin/kcmkwin/kwindecoration/decorationmodel.h 0a5a116 =

>   kwin/kcmkwin/kwindecoration/decorationmodel.cpp 4915d10 =

>   kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209 =

>   kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml 8db4065 =

>   kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml PRE-CREATION =

>   kwin/kcmkwin/kwindecoration/qml/main.qml 9ca0e89 =

> =

> Diff: http://git.reviewboard.kde.org/r/105768/diff/
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> Old and new Plastik
>   http://git.reviewboard.kde.org/r/105768/s/648/
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>


--===============1207995244355305637==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/105768/">http://git.revie=
wboard.kde.org/r/105768/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This revie=
w has been submitted with commit 11325bf8f643339bb83a9f8ebcb706e03332ff72 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On August 25th, 2012, 9:15 a.m., Martin Gr=C3=A4=C3=9Flin wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gr=C3=A4=C3=9Flin.</div>


<p style=3D"color: grey;"><i>Updated Aug. 25, 2012, 9:15 a.m.</i></p>






<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This is the other part to the review request for QML support=
 in Aurorae. The buttons are a little bit of cheating as they are rendered =
in C++ through an extension plugin.

Currently there are a few regressions compared to the native variant:
* colored border option is not supported, I&#39;m not really sure what it a=
ctually does
* explicit button spacer is too small
* corners are not yet rounded
</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/CMakeLists.txt <span style=3D"color: grey">(f5eeb=
71)</span></li>

 <li>kwin/clients/aurorae/src/CMakeLists.txt <span style=3D"color: grey">(7=
1be39a)</span></li>

 <li>kwin/clients/aurorae/src/aurorae.h <span style=3D"color: grey">(fabd82=
8)</span></li>

 <li>kwin/clients/aurorae/src/aurorae.cpp <span style=3D"color: grey">(4277=
b65)</span></li>

 <li>kwin/clients/aurorae/src/colorhelper.h <span style=3D"color: grey">(PR=
E-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/colorhelper.cpp <span style=3D"color: grey">(=
PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/decorationoptions.h <span style=3D"color: gre=
y">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/decorationoptions.cpp <span style=3D"color: g=
rey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/decorationplugin.h <span style=3D"color: grey=
">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/decorationplugin.cpp <span style=3D"color: gr=
ey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/kwindecoration.desktop <span style=3D"color: =
grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/qml/ButtonGroup.qml <span style=3D"color: gre=
y">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/src/qml/MenuButton.qml <span style=3D"color: grey=
">(e2f67ec)</span></li>

 <li>kwin/clients/aurorae/src/qml/aurorae.qml <span style=3D"color: grey">(=
acd6d7a)</span></li>

 <li>kwin/clients/aurorae/src/qml/qmldir <span style=3D"color: grey">(PRE-C=
REATION)</span></li>

 <li>kwin/clients/aurorae/themes/CMakeLists.txt <span style=3D"color: grey"=
>(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/CMakeLists.txt <span style=3D"colo=
r: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt <span style=3D=
"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.h <span style=
=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp <span style=
=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.h <span style=
=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp <span style=
=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/code/qmldir <span style=3D"color: =
grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/package/contents/config/main.xml <=
span style=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.=
qml <span style=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/package/contents/ui/config.ui <spa=
n style=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span=
 style=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/clients/aurorae/themes/plastik/package/metadata.desktop <span sty=
le=3D"color: grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style=3D"color: grey"=
>(da02993)</span></li>

 <li>kwin/kcmkwin/kwindecoration/auroraeconfig.ui <span style=3D"color: gre=
y">(7762140)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style=3D"color: gr=
ey">(0a5a116)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style=3D"color: =
grey">(4915d10)</span></li>

 <li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style=3D"color: g=
rey">(1f7a209)</span></li>

 <li>kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml <span style=3D"c=
olor: grey">(8db4065)</span></li>

 <li>kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml <span style=3D"c=
olor: grey">(PRE-CREATION)</span></li>

 <li>kwin/kcmkwin/kwindecoration/qml/main.qml <span style=3D"color: grey">(=
9ca0e89)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/105768/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>



<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Screensho=
ts </h1>

<div>

 <a href=3D"http://git.reviewboard.kde.org/r/105768/s/648/"><img src=3D"htt=
p://git.reviewboard.kde.org/media/uploaded/images/2012/07/28/plastik-qml-bu=
ttons_400x100.png" style=3D"border: 1px black solid;" alt=3D"Old and new Pl=
astik" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============1207995244355305637==--

--===============7674937747920057903==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============7674937747920057903==--