[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: QML theme support in Aurorae Decorations
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-26 19:00:17
Message-ID: 20120826190017.20788.99963 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105751/#review18048
-----------------------------------------------------------
This review has been submitted with commit 11325bf8f643339bb83a9f8ebcb706e03332ff72 \
by Martin Gräßlin to branch master.
- Commit Hook
On July 29, 2012, 11:42 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105751/
> -----------------------------------------------------------
>
> (Updated July 29, 2012, 11:42 a.m.)
>
>
> Review request for kwin and Antonis Tsiapaliokas.
>
>
> Description
> -------
>
> Adds support for QML based window decorations distributed through Plasma Packages \
> structures. It adds a declarative plugin containing the needed bits for making \
> window decorations work.
> @Antonis: please have a look whether this matches your changes to plasmapkg
>
>
> This addresses bug 303810.
> http://bugs.kde.org/show_bug.cgi?id=303810
>
>
> Diffs
> -----
>
> kwin/clients/aurorae/src/CMakeLists.txt 71be39a
> kwin/clients/aurorae/src/aurorae.h 9c20787
> kwin/clients/aurorae/src/aurorae.cpp ed5942e
> kwin/clients/aurorae/src/colorhelper.h PRE-CREATION
> kwin/clients/aurorae/src/colorhelper.cpp PRE-CREATION
> kwin/clients/aurorae/src/decorationoptions.h PRE-CREATION
> kwin/clients/aurorae/src/decorationoptions.cpp PRE-CREATION
> kwin/clients/aurorae/src/decorationplugin.h PRE-CREATION
> kwin/clients/aurorae/src/decorationplugin.cpp PRE-CREATION
> kwin/clients/aurorae/src/kwindecoration.desktop PRE-CREATION
> kwin/clients/aurorae/src/qml/ButtonGroup.qml PRE-CREATION
> kwin/clients/aurorae/src/qml/qmldir PRE-CREATION
> kwin/kcmkwin/kwindecoration/CMakeLists.txt da02993
> kwin/kcmkwin/kwindecoration/decorationmodel.h 0a5a116
> kwin/kcmkwin/kwindecoration/decorationmodel.cpp b945606
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp 34d9b48
> kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml 8db4065
> kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml PRE-CREATION
> kwin/kcmkwin/kwindecoration/qml/main.qml 9ca0e89
>
> Diff: http://git.reviewboard.kde.org/r/105751/diff/
>
>
> Testing
> -------
>
> I have here a half finished port of Plastik to QML. Seems to work fine so far.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105751/">http://git.reviewboard.kde.org/r/105751/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 11325bf8f643339bb83a9f8ebcb706e03332ff72 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 29th, 2012, 11:42 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Antonis Tsiapaliokas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 29, 2012, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds support for QML based window decorations distributed through Plasma \
Packages structures. It adds a declarative plugin containing the needed bits for \
making window decorations work.
@Antonis: please have a look whether this matches your changes to plasmapkg</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have here a half finished port of Plastik to QML. Seems to work fine \
so far.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303810">303810</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/CMakeLists.txt <span style="color: \
grey">(71be39a)</span></li>
<li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(9c20787)</span></li>
<li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(ed5942e)</span></li>
<li>kwin/clients/aurorae/src/colorhelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/colorhelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationoptions.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationoptions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/decorationplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/kwindecoration.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/ButtonGroup.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/src/qml/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style="color: \
grey">(da02993)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(0a5a116)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(b945606)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(34d9b48)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/AuroraeDecoration.qml <span style="color: \
grey">(8db4065)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/DecorationPreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwindecoration/qml/main.qml <span style="color: \
grey">(9ca0e89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105751/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic