'Re: Review Request: Make Bouncing Cursor respect Small Icon size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Make Bouncing Cursor respect Small Icon size
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2012-08-24 16:20:20
Message-ID: 20120824162020.30559.53336 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106166/
-----------------------------------------------------------

(Updated Aug. 24, 2012, 4:20 p.m.)

Review request for kwin.

Changes
-------

Yes, we need FP division. And addressed the not-always-initialized variable.

Description
-------

This patch makes KWin's startup feedback effect aka bouncing cursor respect the \
global small icon size. The icon was loaded correctly but scaled to a fixed size \
previously. (The variable could be given a better name for sure)

This addresses bug 305611.
    http://bugs.kde.org/show_bug.cgi?id=305611

Diffs (updated)
-----

  kwin/effects/startupfeedback/startupfeedback.h 6758354 
  kwin/effects/startupfeedback/startupfeedback.cpp ff6a51e 

Diff: http://git.reviewboard.kde.org/r/106166/diff/

Testing
-------

Tested with 16, 22 and 48 icon size and works fine.

Thanks,

Kai Uwe Broulik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106166/">http://git.reviewboard.kde.org/r/106166/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Aug. 24, 2012, 4:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, we need FP division. And addressed the not-always-initialized \
variable.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes KWin's startup feedback effect aka bouncing cursor \
respect the global small icon size. The icon was loaded correctly but scaled to a \
fixed size previously. (The variable could be given a better name for sure)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with 16, 22 and 48 icon size and works fine.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=305611">305611</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/startupfeedback/startupfeedback.h <span style="color: \
grey">(6758354)</span></li>

 <li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(ff6a51e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106166/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 