'Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2012-08-22 9:34:03
Message-ID: 20120822093403.2876.6314 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/
-----------------------------------------------------------

Review request for kwin, Plasma, Sebastian K=C3=BCgler, Martin Gr=C3=A4=C3=
=9Flin, and Giorgos Tsiapaliwkas.

Description
-------

Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being c=
alled.
Also on the toolbar, there is a new action with name "konsole". This action=
 is visible only when we are inside to a KWin Script.
All the other packages, have a previewer. So the "konsole" action is locate=
d inside the previewer.

Diffs
-----

  konsole/konsolepreviewer.h 8dd4369 =

  konsole/konsolepreviewer.cpp c4f9f8b =

  main.cpp 298be51 =

  mainwindow.h 8005d26 =

  mainwindow.cpp b84da4a =

  plasmateui.rc b51884d =

Diff: http://git.reviewboard.kde.org/r/106118/diff/

Testing
-------

Screenshots
-----------

konsole
  http://git.reviewboard.kde.org/r/106118/s/693/

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106118/">http://git.reviewboard.kde.org/r/106118/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and \
Giorgos Tsiapaliwkas.</div> <div>By Antonis Tsiapaliokas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the &quot;Execute&quot; button, then the script is being \
called. Also on the toolbar, there is a new action with name &quot;konsole&quot;. \
This action is visible only when we are inside to a KWin Script. All the other \
packages, have a previewer. So the &quot;konsole&quot; action is located inside the \
previewer.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konsole/konsolepreviewer.h <span style="color: grey">(8dd4369)</span></li>

 <li>konsole/konsolepreviewer.cpp <span style="color: grey">(c4f9f8b)</span></li>

 <li>main.cpp <span style="color: grey">(298be51)</span></li>

 <li>mainwindow.h <span style="color: grey">(8005d26)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(b84da4a)</span></li>

 <li>plasmateui.rc <span style="color: grey">(b51884d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106118/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106118/s/693/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/22/kwin_script_konsole_previewer_400x100.png" \
style="border: 1px black solid;" alt="konsole" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 