[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Focus Tracking in KWin's Zoom Plugin
From: "Frederik Gladhorn" <gladhorn () kde ! org>
Date: 2012-08-21 9:49:32
Message-ID: 20120821094932.23810.8217 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106041/#review17796
-----------------------------------------------------------
kwin/effects/zoom/zoom.cpp
<http://git.reviewboard.kde.org/r/106041/#comment14037>
This is in the dtor of registry, I don't think it makes much sense sett=
ing the member to 0 here.
kwin/effects/zoom/zoom.cpp
<http://git.reviewboard.kde.org/r/106041/#comment14038>
You could also simply use disconnect(registry). Deleting it also discon=
nects it automatically btw.
- Frederik Gladhorn
On Aug. 19, 2012, 8:53 a.m., Amandeep Singh wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106041/
> -----------------------------------------------------------
> =
> (Updated Aug. 19, 2012, 8:53 a.m.)
> =
> =
> Review request for KDE Accessibility, kwin, Frederik Gladhorn, Sebastian =
Sauer, and Lubo=C5=A1 Lu=C5=88=C3=A1k.
> =
> =
> Description
> -------
> =
> This patch is for KWin, makes the focus-tracking feature of KWin work wit=
h applications. This makes KDE more accessible.
> A new accessibility client library "libkdeaccessibilityclient" (which can=
be found here: https://projects.kde.org/projects/playground/accessibility/=
libkdeaccessibilityclient) is also to be added in kde-support.
> =
> The focus-tracking feature will use the new library to get the accessibil=
ity information from at-spi.
> =
> Adjustments in CMakeLists have been made to add the library as an optiona=
l dependency, which if found enables the focus-tracking option in Zoom Plug=
in.
> And in absence of library, the option is removed.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 451a8b9 =
> config-workspace.h.cmake 4a2dcbf =
> kwin/effects/CMakeLists.txt 29accb1 =
> kwin/effects/configs_builtins.cpp b291e38 =
> kwin/effects/zoom/CMakeLists.txt 36e11ac =
> kwin/effects/zoom/zoom.h d809b21 =
> kwin/effects/zoom/zoom.cpp b275b1e =
> kwin/effects/zoom/zoom_config.cpp 3edd10c =
> =
> Diff: http://git.reviewboard.kde.org/r/106041/diff/
> =
> =
> Testing
> -------
> =
> I tested KWin's new feature working with KWrite and Konsole.
> =
> =
> Thanks,
> =
> Amandeep Singh
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106041/">http://git.reviewboard.kde.org/r/106041/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106041/diff/3/?file=78640#file78640line143" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/zoom/zoom.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ZoomEffect::~ZoomEffect()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">141</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">registry</span> <span class="o">=</span> <span class="nb">NULL</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is in \
the dtor of registry, I don't think it makes much sense setting the member to 0 \
here.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106041/diff/3/?file=78640#file78640line236" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/zoom/zoom.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ZoomEffect::recreateTexture()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">234</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">disconnect</span><span class="p">(</span><span \
class="n">registry</span><span class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could \
also simply use disconnect(registry). Deleting it also disconnects it automatically \
btw.</pre> </div>
<br />
<p>- Frederik</p>
<br />
<p>On August 19th, 2012, 8:53 a.m., Amandeep Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Accessibility, kwin, Frederik Gladhorn, Sebastian Sauer, \
and Luboš Luňák.</div> <div>By Amandeep Singh.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 8:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is for KWin, makes the focus-tracking feature of KWin work \
with applications. This makes KDE more accessible. A new accessibility client library \
"libkdeaccessibilityclient" (which can be found here: \
https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient) \
is also to be added in kde-support.
The focus-tracking feature will use the new library to get the accessibility \
information from at-spi.
Adjustments in CMakeLists have been made to add the library as an optional \
dependency, which if found enables the focus-tracking option in Zoom Plugin. And in \
absence of library, the option is removed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested KWin's new feature working with KWrite and Konsole.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(451a8b9)</span></li>
<li>config-workspace.h.cmake <span style="color: grey">(4a2dcbf)</span></li>
<li>kwin/effects/CMakeLists.txt <span style="color: grey">(29accb1)</span></li>
<li>kwin/effects/configs_builtins.cpp <span style="color: \
grey">(b291e38)</span></li>
<li>kwin/effects/zoom/CMakeLists.txt <span style="color: grey">(36e11ac)</span></li>
<li>kwin/effects/zoom/zoom.h <span style="color: grey">(d809b21)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: grey">(b275b1e)</span></li>
<li>kwin/effects/zoom/zoom_config.cpp <span style="color: \
grey">(3edd10c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106041/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic