[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Use the first client as entrance to the focus chain if no active window
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-08-20 14:15:35
Message-ID: 20120820141535.25870.80734 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 19, 2012, 5:39 p.m., Martin Gräßlin wrote:
> > kwin/tabbox/clientmodel.cpp, line 141
> > <http://git.reviewboard.kde.org/r/106088/diff/1/?file=78714#file78714line141>
> >
> > this is another bug uncovered by the unit test. Even if the list is empty it returned 1.
That code is btw. NOT in master (but plain return m_clientList.count();)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106088/#review17717
-----------------------------------------------------------
On Aug. 19, 2012, 7:09 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106088/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2012, 7:09 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Use the first client as entrance to the focus chain if no active window
>
> The recently used mode of TabBox uses the active window as the entrance
> into the focus chain. If there is no active window it does not find any
> Clients. To solve this issue the ClientModel now uses the first entry
> of the focus chain in case there is no active window.
>
> BUG: 305449
> FIXED-IN: 4.9.1
>
>
> This addresses bug 305449.
> http://bugs.kde.org/show_bug.cgi?id=305449
>
>
> Diffs
> -----
>
> kwin/tabbox/clientmodel.cpp b78c1f5ce4e92d555496aa7f28b24d098c66eeff
> kwin/tabbox/tabbox.h bf69ad91840b4065e445998d26baa1795ba9a460
> kwin/tabbox/tabbox.cpp 098d7598c0a3759f91cd4c92f8795c6a713d1fa8
> kwin/tabbox/tabboxhandler.h 976f2017358a9dfefdd499b7109ffb2f64bd2681
> kwin/tabbox/tests/mock_tabboxhandler.h f13a820aac719a6578c4fd35de2e534faa1f4aeb
> kwin/tabbox/tests/mock_tabboxhandler.cpp 1d27dc752b44dfe8d518449ad65df82c6e2392b3
> kwin/tabbox/tests/test_tabbox_clientmodel.h 1bdf0d4aa416bdb0f4dbd040ac2a0bb73c5165fc
> kwin/tabbox/tests/test_tabbox_clientmodel.cpp cd2c9636299365cda777b07b1ba8010965b0b560
>
> Diff: http://git.reviewboard.kde.org/r/106088/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106088/">http://git.reviewboard.kde.org/r/106088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 19th, 2012, 5:39 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106088/diff/1/?file=78714#file78714line141" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/tabbox/clientmodel.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
ClientModel::rowCount(const QModelIndex& parent) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">141</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n"><span class="hl">qMax</span></span><span \
class="p"><span class="hl">(</span></span><span class="n">count</span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="mi"><span class="hl">1</span></span><span class="p"><span \
class="hl">)</span>;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">141</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span \
class="n">count</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is another bug \
uncovered by the unit test. Even if the list is empty it returned 1.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That code \
is btw. NOT in master (but plain return m_clientList.count();)</pre> <br />
<p>- Thomas</p>
<br />
<p>On August 19th, 2012, 7:09 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 7:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the first client as entrance to the focus chain if no active window
The recently used mode of TabBox uses the active window as the entrance
into the focus chain. If there is no active window it does not find any
Clients. To solve this issue the ClientModel now uses the first entry
of the focus chain in case there is no active window.
BUG: 305449
FIXED-IN: 4.9.1</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305449">305449</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/clientmodel.cpp <span style="color: \
grey">(b78c1f5ce4e92d555496aa7f28b24d098c66eeff)</span></li>
<li>kwin/tabbox/tabbox.h <span style="color: \
grey">(bf69ad91840b4065e445998d26baa1795ba9a460)</span></li>
<li>kwin/tabbox/tabbox.cpp <span style="color: \
grey">(098d7598c0a3759f91cd4c92f8795c6a713d1fa8)</span></li>
<li>kwin/tabbox/tabboxhandler.h <span style="color: \
grey">(976f2017358a9dfefdd499b7109ffb2f64bd2681)</span></li>
<li>kwin/tabbox/tests/mock_tabboxhandler.h <span style="color: \
grey">(f13a820aac719a6578c4fd35de2e534faa1f4aeb)</span></li>
<li>kwin/tabbox/tests/mock_tabboxhandler.cpp <span style="color: \
grey">(1d27dc752b44dfe8d518449ad65df82c6e2392b3)</span></li>
<li>kwin/tabbox/tests/test_tabbox_clientmodel.h <span style="color: \
grey">(1bdf0d4aa416bdb0f4dbd040ac2a0bb73c5165fc)</span></li>
<li>kwin/tabbox/tests/test_tabbox_clientmodel.cpp <span style="color: \
grey">(cd2c9636299365cda777b07b1ba8010965b0b560)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106088/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic