[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Ensure main.qml presence in decoration kcm
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-19 11:29:40
Message-ID: 20120819112940.1371.79805 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106062/#review17700
-----------------------------------------------------------
Ship it!
I think it's OK to make the complete dialog inaccessible. Probably more is broken \
than just this KCM if the package is broken.
kwin/kcmkwin/kwindecoration/kwindecoration.cpp
<http://git.reviewboard.kde.org/r/106062/#comment13841>
I would use "Installation Error" as title
- Martin Gräßlin
On Aug. 18, 2012, 10:11 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106062/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2012, 10:11 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> This handles it gracefully.
> Given the kcm is usually in and will crash systemsettings i've a slight tendency \
> towards this but would also be fine with an assert (or straight abort regardless of \
> compile mode)
> Ratio:
> The code relies on the presence of an extern resource and produces "funny" crashes \
> if absent - that somebody has to investigate.
> I also propose to check kwin for similar hard deps on extern resources and handle \
> them in a common way.
>
> This addresses bug 304881.
> http://bugs.kde.org/show_bug.cgi?id=304881
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209
>
> Diff: http://git.reviewboard.kde.org/r/106062/diff/
>
>
> Testing
> -------
>
> Yes, deleted main.qml -> crash.
> W/ patch I get an ugly label telling me that i shall contact my distro because an \
> important file is missing.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106062/">http://git.reviewboard.kde.org/r/106062/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it's OK to \
make the complete dialog inaccessible. Probably more is broken than just this KCM if \
the package is broken.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106062/diff/2/?file=78405#file78405line88" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kcmkwin/kwindecoration/kwindecoration.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KWinDecorationModule::KWinDecorationModule(QWidget* parent, const QVariantList \
&)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">88</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"The application will now abort"</span><span class="p">,</span> \
<span class="s">"Missing an important file"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would use \
"Installation Error" as title</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On August 18th, 2012, 10:11 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 10:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This handles it gracefully. Given the kcm is usually in and will crash \
systemsettings i've a slight tendency towards this but would also be fine with an \
assert (or straight abort regardless of compile mode)
Ratio:
The code relies on the presence of an extern resource and produces "funny" \
crashes if absent - that somebody has to investigate.
I also propose to check kwin for similar hard deps on extern resources and handle \
them in a common way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, deleted main.qml -> crash. W/ patch I get an ugly label telling \
me that i shall contact my distro because an important file is missing.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304881">304881</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(1f7a209)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106062/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic