[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Adding a screen menu to the Client's useraction menu
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-18 7:45:43
Message-ID: 20120818074543.25126.95339 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106065/#review17641
-----------------------------------------------------------
This review has been submitted with commit 1739330fa5cf7bc074af16acb8214e1cec4e53f2 \
by Martin Gräßlin to branch master.
- Commit Hook
On Aug. 17, 2012, 8:37 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106065/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2012, 8:37 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Adding a screen menu to the Client's useraction menu
>
> New "Move To Screen" menu is shown after the "Move To Desktop"
> menu if there are multiple screens and the window can be moved
> to another screen. Menu contains one radio button for each
> screen.
>
> Selecting an entry sends the Client to the selected screen.
>
> BUG: 269207
> FIXED-IN: 4.10
>
>
> This addresses bug 269207.
> http://bugs.kde.org/show_bug.cgi?id=269207
>
>
> Diffs
> -----
>
> kwin/useractions.cpp c8cff3055229f0ff5abeb9c1bceb8514dd1a5c9c
> kwin/workspace.h a21c7f83135eee79d8401099182dccc67ad8c5e7
> kwin/workspace.cpp a0cef15807e738d5ff40cf9ff8e6776ff05533ea
>
> Diff: http://git.reviewboard.kde.org/r/106065/diff/
>
>
> Testing
> -------
>
> * only tested in multi screen setup
> * created a window rule to have a window not moveable -> menu not shown
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106065/">http://git.reviewboard.kde.org/r/106065/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1739330fa5cf7bc074af16acb8214e1cec4e53f2 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 17th, 2012, 8:37 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 8:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding a screen menu to the Client's useraction menu
New "Move To Screen" menu is shown after the "Move To Desktop"
menu if there are multiple screens and the window can be moved
to another screen. Menu contains one radio button for each
screen.
Selecting an entry sends the Client to the selected screen.
BUG: 269207
FIXED-IN: 4.10</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* only tested in multi screen setup
* created a window rule to have a window not moveable -> menu not shown</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=269207">269207</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: \
grey">(c8cff3055229f0ff5abeb9c1bceb8514dd1a5c9c)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(a21c7f83135eee79d8401099182dccc67ad8c5e7)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(a0cef15807e738d5ff40cf9ff8e6776ff05533ea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106065/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic