[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Effects can provide support information through properties
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-17 15:54:46
Message-ID: 20120817155446.3566.87453 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105977/#review17610
-----------------------------------------------------------
This review has been submitted with commit 42aa9c80217f8f23a1ad3947ee1d8ba0=
748ad277 by Martin Gr=C3=A4=C3=9Flin to branch KDE/4.9.
- Commit Hook
On Aug. 11, 2012, 9:35 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105977/
> -----------------------------------------------------------
> =
> (Updated Aug. 11, 2012, 9:35 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Effects can provide support information through properties
> =
> The supportInformation is extended to also read the properties
> on all effects. In addition each effect can be queried just for
> itself through D-Bus, e.g.:
> qdbus org.kde.kwin /KWin supportInformationForEffect kwin4_effect_blur
> =
> All effects are extended to provide their configured and read
> settings through properties. In some cases also important
> runtime information is exposed.
> =
> =
> Diffs
> -----
> =
> kwin/effects.h a65909d231053c738f878691daba85e07d1738ba =
> kwin/effects.cpp 352799177dc531dfc6ab464fe4c9c44eefb37911 =
> kwin/effects/blur/blur.h ce2eac40ffc686c9b2dd212a6664643c2f4f0c84 =
> kwin/effects/blur/blur.cpp feba0361281e533b7c9672de5026ff79659af1f6 =
> kwin/effects/coverswitch/coverswitch.h cfc1cdd931afc6422a644cb3d9417c7d=
d62bd203 =
> kwin/effects/cube/cube.h cb2b576d419cf48872f59ca3925e25f320a735c8 =
> kwin/effects/cube/cubeslide.h 96b814840cfdd06ad4c72e353e4e3eb6a68669db =
> kwin/effects/dashboard/dashboard.h 80df408c264fe10a82661f4191ce9ce020d5=
8d8d =
> kwin/effects/desktopgrid/desktopgrid.h 1bdf1c242614ff044b73584e1a7e086b=
67f3a6c5 =
> kwin/effects/dialogparent/dialogparent.h 95814b01885b211df21f414dc601f4=
b531124336 =
> kwin/effects/diminactive/diminactive.h b9c3c281d95a6cf5a044b2418e84d656=
c6b69159 =
> kwin/effects/fallapart/fallapart.h 8dfcf29a3a0c4401bd61b792291f118803c9=
3e97 =
> kwin/effects/flipswitch/flipswitch.h a645b2a2a78ca35284e292785610597bf2=
6c2e2a =
> kwin/effects/glide/glide.h 6e0cbda6eeab824db31ac00d7eed8cd95899f2df =
> kwin/effects/login/login.h a25da79a80ed28c91052b08f0a12556f6773566b =
> kwin/effects/logout/logout.h f3f69b21fbe5f8482e645fa43003337df3c0d51f =
> kwin/effects/lookingglass/lookingglass.h 892f9a20ce2dbd85b8d0d111fd0adc=
0723441343 =
> kwin/effects/magiclamp/magiclamp.h 6131a162938a49601ca056455d9cf1439750=
08b2 =
> kwin/effects/magnifier/magnifier.h 979685373a46003df88e2c9f21be0b39ad60=
38c4 =
> kwin/effects/mousemark/mousemark.h ccf551d84616825caac38ebf2cfcf4f12f9c=
3ecb =
> kwin/effects/presentwindows/presentwindows.h 71052660b58b1bd64fd7239f24=
492652e6624f36 =
> kwin/effects/resize/resize.h d6c815c6c1ff5f4129ca70799717faef05d745f2 =
> kwin/effects/sheet/sheet.h abee09ae2552ad5fb02d338f5d65d597ec174506 =
> kwin/effects/showfps/showfps.h 61be61faf34a6f7007f3ad7736f43b48ff39de2d =
> kwin/effects/slidingpopups/slidingpopups.h dd51af9d98bf09760b43dc8aaffa=
c6aae5c2e4c3 =
> kwin/effects/thumbnailaside/thumbnailaside.h 5bb66589cf74a3cc1cd58cf07c=
6f46823e03a53f =
> kwin/effects/trackmouse/trackmouse.h 731e760eb3956407abcd551a635d3732bc=
780541 =
> kwin/effects/translucency/translucency.h 193af57feaaccc26c447ad239eb2d9=
2207b4a439 =
> kwin/effects/windowgeometry/windowgeometry.h 789ccfc3958b2f1278357712da=
63e8e84783a2e1 =
> kwin/effects/wobblywindows/wobblywindows.h 94c2e9abf401d96b7f52f965ca45=
6abce798ce47 =
> kwin/effects/zoom/zoom.h d809b21877c0c4eb561f234e465704d6e9c76144 =
> kwin/org.kde.KWin.xml 2e8eee595e8a330cd7000a0c30b2bdaaac02f1df =
> kwin/useractions.cpp 2aec51e4ce7f2dac6b695bea732355749652a09d =
> kwin/workspace.h 2f7fe19429989b6b568d635a475d865cf6e49c2e =
> kwin/workspace.cpp d973a89a1ef0d804be85f3e21ee6e459618ab7cb =
> =
> Diff: http://git.reviewboard.kde.org/r/105977/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105977/">http://git.reviewboard.kde.org/r/105977/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 42aa9c80217f8f23a1ad3947ee1d8ba0748ad277 by Martin Gräßlin to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 11th, 2012, 9:35 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 9:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Effects can provide support information through properties
The supportInformation is extended to also read the properties
on all effects. In addition each effect can be queried just for
itself through D-Bus, e.g.:
qdbus org.kde.kwin /KWin supportInformationForEffect kwin4_effect_blur
All effects are extended to provide their configured and read
settings through properties. In some cases also important
runtime information is exposed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: \
grey">(a65909d231053c738f878691daba85e07d1738ba)</span></li>
<li>kwin/effects.cpp <span style="color: \
grey">(352799177dc531dfc6ab464fe4c9c44eefb37911)</span></li>
<li>kwin/effects/blur/blur.h <span style="color: \
grey">(ce2eac40ffc686c9b2dd212a6664643c2f4f0c84)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: \
grey">(feba0361281e533b7c9672de5026ff79659af1f6)</span></li>
<li>kwin/effects/coverswitch/coverswitch.h <span style="color: \
grey">(cfc1cdd931afc6422a644cb3d9417c7dd62bd203)</span></li>
<li>kwin/effects/cube/cube.h <span style="color: \
grey">(cb2b576d419cf48872f59ca3925e25f320a735c8)</span></li>
<li>kwin/effects/cube/cubeslide.h <span style="color: \
grey">(96b814840cfdd06ad4c72e353e4e3eb6a68669db)</span></li>
<li>kwin/effects/dashboard/dashboard.h <span style="color: \
grey">(80df408c264fe10a82661f4191ce9ce020d58d8d)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(1bdf1c242614ff044b73584e1a7e086b67f3a6c5)</span></li>
<li>kwin/effects/dialogparent/dialogparent.h <span style="color: \
grey">(95814b01885b211df21f414dc601f4b531124336)</span></li>
<li>kwin/effects/diminactive/diminactive.h <span style="color: \
grey">(b9c3c281d95a6cf5a044b2418e84d656c6b69159)</span></li>
<li>kwin/effects/fallapart/fallapart.h <span style="color: \
grey">(8dfcf29a3a0c4401bd61b792291f118803c93e97)</span></li>
<li>kwin/effects/flipswitch/flipswitch.h <span style="color: \
grey">(a645b2a2a78ca35284e292785610597bf26c2e2a)</span></li>
<li>kwin/effects/glide/glide.h <span style="color: \
grey">(6e0cbda6eeab824db31ac00d7eed8cd95899f2df)</span></li>
<li>kwin/effects/login/login.h <span style="color: \
grey">(a25da79a80ed28c91052b08f0a12556f6773566b)</span></li>
<li>kwin/effects/logout/logout.h <span style="color: \
grey">(f3f69b21fbe5f8482e645fa43003337df3c0d51f)</span></li>
<li>kwin/effects/lookingglass/lookingglass.h <span style="color: \
grey">(892f9a20ce2dbd85b8d0d111fd0adc0723441343)</span></li>
<li>kwin/effects/magiclamp/magiclamp.h <span style="color: \
grey">(6131a162938a49601ca056455d9cf143975008b2)</span></li>
<li>kwin/effects/magnifier/magnifier.h <span style="color: \
grey">(979685373a46003df88e2c9f21be0b39ad6038c4)</span></li>
<li>kwin/effects/mousemark/mousemark.h <span style="color: \
grey">(ccf551d84616825caac38ebf2cfcf4f12f9c3ecb)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(71052660b58b1bd64fd7239f24492652e6624f36)</span></li>
<li>kwin/effects/resize/resize.h <span style="color: \
grey">(d6c815c6c1ff5f4129ca70799717faef05d745f2)</span></li>
<li>kwin/effects/sheet/sheet.h <span style="color: \
grey">(abee09ae2552ad5fb02d338f5d65d597ec174506)</span></li>
<li>kwin/effects/showfps/showfps.h <span style="color: \
grey">(61be61faf34a6f7007f3ad7736f43b48ff39de2d)</span></li>
<li>kwin/effects/slidingpopups/slidingpopups.h <span style="color: \
grey">(dd51af9d98bf09760b43dc8aaffac6aae5c2e4c3)</span></li>
<li>kwin/effects/thumbnailaside/thumbnailaside.h <span style="color: \
grey">(5bb66589cf74a3cc1cd58cf07c6f46823e03a53f)</span></li>
<li>kwin/effects/trackmouse/trackmouse.h <span style="color: \
grey">(731e760eb3956407abcd551a635d3732bc780541)</span></li>
<li>kwin/effects/translucency/translucency.h <span style="color: \
grey">(193af57feaaccc26c447ad239eb2d92207b4a439)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.h <span style="color: \
grey">(789ccfc3958b2f1278357712da63e8e84783a2e1)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows.h <span style="color: \
grey">(94c2e9abf401d96b7f52f965ca456abce798ce47)</span></li>
<li>kwin/effects/zoom/zoom.h <span style="color: \
grey">(d809b21877c0c4eb561f234e465704d6e9c76144)</span></li>
<li>kwin/org.kde.KWin.xml <span style="color: \
grey">(2e8eee595e8a330cd7000a0c30b2bdaaac02f1df)</span></li>
<li>kwin/useractions.cpp <span style="color: \
grey">(2aec51e4ce7f2dac6b695bea732355749652a09d)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(2f7fe19429989b6b568d635a475d865cf6e49c2e)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(d973a89a1ef0d804be85f3e21ee6e459618ab7cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105977/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic