'Review Request: Split out Compositor into an own class'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Split out Compositor into an own class
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-08-17 11:34:10
Message-ID: 20120817113410.15871.52087 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106060/
-----------------------------------------------------------

Review request for kwin and Arthur Arlt.

Description
-------

Based on review request 102420 which got rebased on current master. In addi=
tion some further work has been added by me:
* renamed a few methods and variables, by dropping compositing prefixes
* made the Scene a private member of the Compositor class. Outside the comp=
ositor it has only been used to determine whether Compositing is active.
* moved reinitCompositing and restartKWin from Workspace to Compositor

Further planned work once this is in master:
* better way to determine whether Compositing is active (currently no longe=
r an inline method)
* export /Compositor on D-Bus interface
* deprecate the Compositing related D-Bus methods in the Workspace interface
* maybe make EffectsHandlerImpl a private member of Compositor

Diffs
-----

  kwin/activation.cpp 7c07d5e =

  kwin/bridge.cpp 32d4c84 =

  kwin/client.cpp c541595 =

  kwin/composite.h PRE-CREATION =

  kwin/composite.cpp c65716b =

  kwin/effects.h a65909d =

  kwin/effects.cpp 216a45c =

  kwin/events.cpp 6856922 =

  kwin/geometry.cpp edca219 =

  kwin/layers.cpp 4521554 =

  kwin/paintredirector.cpp 7ed4d6f =

  kwin/scene.h 3891198 =

  kwin/scene.cpp 5782510 =

  kwin/scene_opengl.h de33ce4 =

  kwin/scene_opengl.cpp cbcc0ca =

  kwin/toplevel.h aba9321 =

  kwin/toplevel.cpp 9417813 =

  kwin/utils.h 9eb3589 =

  kwin/workspace.h 5f281b8 =

  kwin/workspace.cpp ecf0d76 =

Diff: http://git.reviewboard.kde.org/r/106060/diff/

Testing
-------

currently running and have not noticed any problems except KWin crashes on =
Shutdown. Will investigate once I see the proper highlighted diff in the in=
terface

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106060/">http://git.reviewboard.kde.org/r/106060/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Arthur Arlt.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Based on review request 102420 which got rebased on current master. In \
                addition some further work has been added by me:
* renamed a few methods and variables, by dropping compositing prefixes
* made the Scene a private member of the Compositor class. Outside the compositor it \
                has only been used to determine whether Compositing is active.
* moved reinitCompositing and restartKWin from Workspace to Compositor

Further planned work once this is in master:
* better way to determine whether Compositing is active (currently no longer an \
                inline method)
* export /Compositor on D-Bus interface
* deprecate the Compositing related D-Bus methods in the Workspace interface
* maybe make EffectsHandlerImpl a private member of Compositor</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">currently running and have not noticed any problems except KWin crashes \
on Shutdown. Will investigate once I see the proper highlighted diff in the \
interface</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/activation.cpp <span style="color: grey">(7c07d5e)</span></li>

 <li>kwin/bridge.cpp <span style="color: grey">(32d4c84)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(c541595)</span></li>

 <li>kwin/composite.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(c65716b)</span></li>

 <li>kwin/effects.h <span style="color: grey">(a65909d)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(216a45c)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(6856922)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(edca219)</span></li>

 <li>kwin/layers.cpp <span style="color: grey">(4521554)</span></li>

 <li>kwin/paintredirector.cpp <span style="color: grey">(7ed4d6f)</span></li>

 <li>kwin/scene.h <span style="color: grey">(3891198)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(5782510)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(de33ce4)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(cbcc0ca)</span></li>

 <li>kwin/toplevel.h <span style="color: grey">(aba9321)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(9417813)</span></li>

 <li>kwin/utils.h <span style="color: grey">(9eb3589)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(5f281b8)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(ecf0d76)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106060/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 