[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Adding a unit test for TabBoxConfig
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-08-15 18:57:46
Message-ID: 20120815185746.29592.37334 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106048/
-----------------------------------------------------------
Review request for kwin.
Description
-------
Adding a unit test for TabBoxConfig
Currently only testing the default ctor and assignment operator.
Inspired by bug fixed with commit 4276161.
Diffs
-----
kwin/tabbox/tests/CMakeLists.txt 1a809ed166041abbda77cfc45426f2be260e90e9 =
kwin/tabbox/tests/test_tabbox_config.cpp PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/106048/diff/
Testing
-------
wrote test before pulling master - test failed. After pulling master the te=
st succeeded.
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106048/">http://git.reviewboard.kde.org/r/106048/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding a unit test for TabBoxConfig
Currently only testing the default ctor and assignment operator.
Inspired by bug fixed with commit 4276161.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">wrote test before pulling master - test failed. After pulling master the \
test succeeded.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/tests/CMakeLists.txt <span style="color: \
grey">(1a809ed166041abbda77cfc45426f2be260e90e9)</span></li>
<li>kwin/tabbox/tests/test_tabbox_config.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106048/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic