[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: hide horizontal wheel events from the deco list declarative scene
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-08-11 20:49:48
Message-ID: 20120811204948.28043.37999 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> On Aug. 11, 2012, 3:06 p.m., Martin Gräßlin wrote:
> > Doubt that it is an upstream bug, but an intended behavior. Like Metro/Windows 8 \
> > which maps vertical scroll wheel to horizontal movement...

The issue here is however that a _horizontal_ wheel event causes weird results by \
moving scene out of bounds (or does otherwise freaky stuff) - it's likely because the \
flickable is not meant to be scrollable at all (eg. the webbrowser demo simply does \
not react on wheel events)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105934/#review17241
-----------------------------------------------------------


On Aug. 8, 2012, 5:59 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105934/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 5:59 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> bug can be reproduced by either having horizontal wheel or "xmodmap -e 'pointer = 1 \
> 2 3 6 7 4 5 8 9 10 11 12 13 14 15 16' (warning: this is nasty ;-) 
> no idea what the scene thinks it does by this reaction, though (may be upstream \
> bug) 
> 
> This addresses bug 304799.
> http://bugs.kde.org/show_bug.cgi?id=304799
> 
> 
> Diffs
> -----
> 
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp 34d9b48 
> 
> Diff: http://git.reviewboard.kde.org/r/105934/diff/
> 
> 
> Testing
> -------
> 
> yes, xmodmap. also ensure there's a vertical offset in the list.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105934/">http://git.reviewboard.kde.org/r/105934/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 11th, 2012, 3:06 p.m., <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Doubt that it is an upstream bug, but an intended behavior. Like \
Metro/Windows 8 which maps vertical scroll wheel to horizontal movement...</pre>  \
</blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The issue here is \
however that a _horizontal_ wheel event causes weird results by moving scene out of \
bounds (or does otherwise freaky stuff) - it&#39;s likely because the flickable is \
not meant to be scrollable at all (eg. the webbrowser demo simply does not react on \
wheel events)</pre> <br />








<p>- Thomas</p>


<br />
<p>On August 8th, 2012, 5:59 p.m., Thomas Lübking wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>


<p style="color: grey;"><i>Updated Aug. 8, 2012, 5:59 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bug can be reproduced by either having horizontal wheel or &quot;xmodmap \
-e &#39;pointer = 1 2 3 6 7 4 5 8 9 10 11 12 13 14 15 16&#39; (warning: this is nasty \
;-)

no idea what the scene thinks it does by this reaction, though (may be upstream \
bug)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, xmodmap. also ensure there&#39;s a vertical offset in the \
list.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=304799">304799</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(34d9b48)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105934/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic