[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: remove startupfeedback effect
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-11 20:32:36
Message-ID: 20120811203236.27415.61715 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105786/#review17255
-----------------------------------------------------------
This review has been submitted with commit 78ec5108a8b7c4e3477e061fd0f1750c5028ec48 \
by Thomas Lübking to branch KDE/4.9.
- Commit Hook
On July 29, 2012, 9:09 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105786/
> -----------------------------------------------------------
>
> (Updated July 29, 2012, 9:09 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> ...bug
> I didn't realize that the feedback region cannot be cached (in the bouncing \
> variant) and for explanation: i added that bug in a mean conspiracy to stop ppl. \
> using ...
> no, wrong line - wait:
>
> ... "it does not happen if you wildly move around the cursor" what was the crucial \
> condition of the bug which got fixed by the breaking commit (and i did not use that \
> effect before or after, sorry)
>
> This addresses bug 304253.
> http://bugs.kde.org/show_bug.cgi?id=304253
>
>
> Diffs
> -----
>
> kwin/effects/startupfeedback/startupfeedback.cpp f3388b5
>
> Diff: http://git.reviewboard.kde.org/r/105786/diff/
>
>
> Testing
> -------
>
> Yes.
> There's also a (hopefully unrelated) bug(?) with the blinking cursor which gets \
> black and white backgrounds instead of brighten/darken/fading (that isn't actually \
> supposed to happen, is it?)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105786/">http://git.reviewboard.kde.org/r/105786/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 78ec5108a8b7c4e3477e061fd0f1750c5028ec48 by Thomas Lübking to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 29th, 2012, 9:09 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated July 29, 2012, 9:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">...bug I didn't realize that the feedback region cannot be cached \
(in the bouncing variant) and for explanation: i added that bug in a mean conspiracy \
to stop ppl. using ...
no, wrong line - wait:
... "it does not happen if you wildly move around the cursor" what was the \
crucial condition of the bug which got fixed by the breaking commit (and i did not \
use that effect before or after, sorry)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. There's also a (hopefully unrelated) bug(?) with the blinking \
cursor which gets black and white backgrounds instead of brighten/darken/fading (that \
isn't actually supposed to happen, is it?)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304253">304253</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(f3388b5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105786/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic