[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: make clientGroupItemDragMimeType a nice source implemeted function
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-08-11 15:21:07
Message-ID: 20120811152107.5499.57650 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 11, 2012, 3:08 p.m., Martin Gräßlin wrote:
> > do we still need it? As far as I understand the crash reports this is not an \
> > issue, but just Ubuntu's packaging completely breaking the ABI.
Theoretically we need it (the symbol is not in the unstable API and not exported the \
way it is) but practically "no" since there's little reason for a stable API deco to \
call this function (the function should never have ended up in any stable namespace)
I'll discard this unless you wish to be extra correct on it.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105855/#review17243
-----------------------------------------------------------
On Aug. 4, 2012, 1:20 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105855/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2012, 1:20 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Christoph Feck.
>
>
> Description
> -------
>
> because despite that kind "export" request it's otherwise apparently not.
>
>
> This addresses bug 301646.
> http://bugs.kde.org/show_bug.cgi?id=301646
>
>
> Diffs
> -----
>
> kwin/libkdecorations/kdecoration.h 614b902
> kwin/libkdecorations/kdecoration.cpp 71f4f8d
>
> Diff: http://git.reviewboard.kde.org/r/105855/diff/
>
>
> Testing
> -------
>
> i grep'd and readelf'd the lib. Otherwise no, sorry.
> I just *hope* this is enough to please the great linker gods...
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105855/">http://git.reviewboard.kde.org/r/105855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 11th, 2012, 3:08 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">do we still need it? As far as I understand the crash reports this is \
not an issue, but just Ubuntu's packaging completely breaking the ABI.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Theoretically we need it \
(the symbol is not in the unstable API and not exported the way it is) but \
practically "no" since there's little reason for a stable API deco to \
call this function (the function should never have ended up in any stable namespace)
I'll discard this unless you wish to be extra correct on it.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On August 4th, 2012, 1:20 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Christoph Feck.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2012, 1:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">because despite that kind "export" request it's otherwise \
apparently not.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i grep'd and readelf'd the lib. Otherwise no, sorry. I just \
*hope* this is enough to please the great linker gods...</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301646">301646</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(614b902)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic