'Re: Review Request: Delay maximize operation by one event cycle'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Delay maximize operation by one event cycle
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-10 14:56:28
Message-ID: 20120810145628.16516.90858 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105961/#review17194
-----------------------------------------------------------

This review has been submitted with commit c0d72b06b842985b36fb70eada6c3f624ab39a3f \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On Aug. 10, 2012, 2:14 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105961/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2012, 2:14 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Delay maximize operation by one event cycle
> 
> The result of maximizing a window might be the decoration
> going away. Because of that we need to delay the handling of
> maximize and title bar double click by one cycle as had been
> done for other close operations in 0fea5325
> 
> BUG: 304870
> FIXED-IN: 4.9.1
> REVIEW: 105961
> 
> 
> This addresses bug 304870.
> http://bugs.kde.org/show_bug.cgi?id=304870
> 
> 
> Diffs
> -----
> 
> kwin/clients/aurorae/src/aurorae.h b3586fd2505acb8076cb28500054aeb25332e6be 
> kwin/clients/aurorae/src/aurorae.cpp 64b4901cf65bc40f630423ad276f9719f87ee58e 
> 
> Diff: http://git.reviewboard.kde.org/r/105961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105961/">http://git.reviewboard.kde.org/r/105961/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c0d72b06b842985b36fb70eada6c3f624ab39a3f by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 10th, 2012, 2:14 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 10, 2012, 2:14 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Delay maximize operation by one event cycle

The result of maximizing a window might be the decoration
going away. Because of that we need to delay the handling of
maximize and title bar double click by one cycle as had been
done for other close operations in 0fea5325

BUG: 304870
FIXED-IN: 4.9.1
REVIEW: 105961</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304870">304870</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(b3586fd2505acb8076cb28500054aeb25332e6be)</span></li>

 <li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(64b4901cf65bc40f630423ad276f9719f87ee58e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105961/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 