'Re: Review Request: Remove outdated options from TabBoxConfig'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Remove outdated options from TabBoxConfig
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-08-10 12:33:37
Message-ID: 20120810123337.5358.81365 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105960/#review17186
-----------------------------------------------------------

Ship it!

Ship It!

- Thomas L=C3=BCbking

On Aug. 10, 2012, 6:11 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105960/
> -----------------------------------------------------------
> =

> (Updated Aug. 10, 2012, 6:11 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Remove outdated options from TabBoxConfig
> =

> Since the QML port the LayoutMode had been hardcoded to vertical
> layout making it a completely useless code-path.
> =

> MinWidth/Height are nowadays completely controlled by the QML
> theme. They were not read anywhere except in the kcm, but there
> not even bound to a ui element.
> =

> The selectedItemLayoutName is also not used anymore with the
> new themes.
> =

> =

> Diffs
> -----
> =

>   kwin/kcmkwin/kwintabbox/main.cpp 5850416e3af130e829577378395ee25afaa67f=
c3 =

>   kwin/tabbox/clientmodel.cpp b78c1f5ce4e92d555496aa7f28b24d098c66eeff =

>   kwin/tabbox/desktopmodel.cpp 0be873980b6aa0a92afee410b0212b7bc495c97a =

>   kwin/tabbox/tabbox.cpp 098d7598c0a3759f91cd4c92f8795c6a713d1fa8 =

>   kwin/tabbox/tabboxconfig.h db02d232bb31a4628dfa014c4c4db3bb4abb3024 =

>   kwin/tabbox/tabboxconfig.cpp 42fdbcf398deed3eb12dfac05ff85f8e67be19c5 =

> =

> Diff: http://git.reviewboard.kde.org/r/105960/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105960/">http://git.reviewboard.kde.org/r/105960/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Thomas</p>

<br />
<p>On August 10th, 2012, 6:11 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 10, 2012, 6:11 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove outdated options from TabBoxConfig

Since the QML port the LayoutMode had been hardcoded to vertical
layout making it a completely useless code-path.

MinWidth/Height are nowadays completely controlled by the QML
theme. They were not read anywhere except in the kcm, but there
not even bound to a ui element.

The selectedItemLayoutName is also not used anymore with the
new themes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwintabbox/main.cpp <span style="color: \
grey">(5850416e3af130e829577378395ee25afaa67fc3)</span></li>

 <li>kwin/tabbox/clientmodel.cpp <span style="color: \
grey">(b78c1f5ce4e92d555496aa7f28b24d098c66eeff)</span></li>

 <li>kwin/tabbox/desktopmodel.cpp <span style="color: \
grey">(0be873980b6aa0a92afee410b0212b7bc495c97a)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: \
grey">(098d7598c0a3759f91cd4c92f8795c6a713d1fa8)</span></li>

 <li>kwin/tabbox/tabboxconfig.h <span style="color: \
grey">(db02d232bb31a4628dfa014c4c4db3bb4abb3024)</span></li>

 <li>kwin/tabbox/tabboxconfig.cpp <span style="color: \
grey">(42fdbcf398deed3eb12dfac05ff85f8e67be19c5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105960/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 