'Re: Review Request: Do not accept left mouse press events on titlebar in Aurorae'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Do not accept left mouse press events on titlebar in Aurorae
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-02 8:51:01
Message-ID: 20120802085101.1993.57005 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105784/#review16787
-----------------------------------------------------------

This review has been submitted with commit 9ee6a775d592ec3f105892c32c7576d6cdd7c210 \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On July 29, 2012, 8:08 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105784/
> -----------------------------------------------------------
> 
> (Updated July 29, 2012, 8:08 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Do not accept left mouse press events on titlebar in Aurorae
> 
> Accepting the mouse events breaks moving the window by dragging
> the title bar. The reason is that it eats the mouse event and
> by that never reaches KWin core to perform the movement.
> 
> Other mouse buttons need to be accepted for handling the window
> operations. Also we need to listen in general to left mouse
> button for the double click operation.
> 
> BUG: 304249
> FIXED-IN: 4.9.1
> 
> 
> This addresses bug 304249.
> http://bugs.kde.org/show_bug.cgi?id=304249
> 
> 
> Diffs
> -----
> 
> kwin/clients/aurorae/src/qml/aurorae.qml 00982b4891fee7f61880fe81f86541776255e069 
> 
> Diff: http://git.reviewboard.kde.org/r/105784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105784/">http://git.reviewboard.kde.org/r/105784/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 9ee6a775d592ec3f105892c32c7576d6cdd7c210 by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 29th, 2012, 8:08 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated July 29, 2012, 8:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not accept left mouse press events on titlebar in Aurorae

Accepting the mouse events breaks moving the window by dragging
the title bar. The reason is that it eats the mouse event and
by that never reaches KWin core to perform the movement.

Other mouse buttons need to be accepted for handling the window
operations. Also we need to listen in general to left mouse
button for the double click operation.

BUG: 304249
FIXED-IN: 4.9.1</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304249">304249</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/qml/aurorae.qml <span style="color: \
grey">(00982b4891fee7f61880fe81f86541776255e069)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105784/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 