'Re: Review Request: Install event filter on Aurorae Decoration to handle WheelEvents'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Install event filter on Aurorae Decoration to handle WheelEvents
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-07-30 20:13:39
Message-ID: 20120730201339.19522.18234 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105801/#review16686
-----------------------------------------------------------

Ship it!

Ship It!

- Thomas Lübking

On July 30, 2012, 6:04 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105801/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 6:04 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Install event filter on Aurorae Decoration to handle WheelEvents
> 
> Unfortunately QtQuick 1 does not provide a way to receive Wheel
> events. But the window decoration needs to pass wheel events on
> the titlebar to KWin core.
> 
> In order to process also Wheel Events in Aurorae an event
> filter is installed on the widget and in case the mouse positon
> is on the title bar the titlebarMouseWheelOperation is invoked.
> 
> BUG: 304248
> FIXED-IN: 4.9.1
> 
> 
> This addresses bug 304248.
>     http://bugs.kde.org/show_bug.cgi?id=304248
> 
> 
> Diffs
> -----
> 
>   kwin/clients/aurorae/src/aurorae.h 9c2078786938e68f9d885c51e8801b95070e6ab7 
>   kwin/clients/aurorae/src/aurorae.cpp ed5942eff046c58030791a71e29addc65ca0029d 
> 
> Diff: http://git.reviewboard.kde.org/r/105801/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105801/">http://git.reviewboard.kde.org/r/105801/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Thomas</p>

<br />
<p>On July 30th, 2012, 6:04 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated July 30, 2012, 6:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Install event filter on Aurorae Decoration to handle WheelEvents

Unfortunately QtQuick 1 does not provide a way to receive Wheel
events. But the window decoration needs to pass wheel events on
the titlebar to KWin core.

In order to process also Wheel Events in Aurorae an event
filter is installed on the widget and in case the mouse positon
is on the title bar the titlebarMouseWheelOperation is invoked.

BUG: 304248
FIXED-IN: 4.9.1</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304248">304248</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(9c2078786938e68f9d885c51e8801b95070e6ab7)</span></li>

 <li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(ed5942eff046c58030791a71e29addc65ca0029d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105801/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 