'Review Request: Deprecate KDecoration's AbilityColor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Deprecate KDecoration's AbilityColor
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-07-29 20:29:06
Message-ID: 20120729202906.27010.88800 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105785/
-----------------------------------------------------------

Review request for kwin.

Description
-------

Deprecate KDecoration's AbilityColor

Nobody is interested in whether the Abilities are supported.
There is one method in KWin core checking for the colors
supported by the currently loaded decoration:
Workspace::decorationSupportedColors

This method is not called from anywhere inside KWin, but is
part of the D-Bus interface, though nobody in KDE's repository
is calling it [1].

As it is part of public API the Abilities are only deprecated
and scheduled for removal with the next big break.

[1] http://lxr.kde.org/search?filestring=&string=decorationSupportedColors

Diffs
-----

  kwin/libkdecorations/kdecoration.h 614b90238a1532360e60d13033434cc4a192d749 
  kwin/org.kde.KWin.xml da7c55afb8189678f2dc77f00e3e2e4beafe5c23 
  kwin/workspace.h 5f281b88f8d0183016d1964f90cf49bc87511ce9 

Diff: http://git.reviewboard.kde.org/r/105785/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105785/">http://git.reviewboard.kde.org/r/105785/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Deprecate KDecoration&#39;s AbilityColor

Nobody is interested in whether the Abilities are supported.
There is one method in KWin core checking for the colors
supported by the currently loaded decoration:
Workspace::decorationSupportedColors

This method is not called from anywhere inside KWin, but is
part of the D-Bus interface, though nobody in KDE&#39;s repository
is calling it [1].

As it is part of public API the Abilities are only deprecated
and scheduled for removal with the next big break.

[1] http://lxr.kde.org/search?filestring=&amp;string=decorationSupportedColors</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(614b90238a1532360e60d13033434cc4a192d749)</span></li>

 <li>kwin/org.kde.KWin.xml <span style="color: \
grey">(da7c55afb8189678f2dc77f00e3e2e4beafe5c23)</span></li>

 <li>kwin/workspace.h <span style="color: \
grey">(5f281b88f8d0183016d1964f90cf49bc87511ce9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105785/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 