'Review Request: Plasmate: Add QML Aurorae decoration support to the startpage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Plasmate: Add QML Aurorae decoration support to the startpage
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2012-07-28 16:50:45
Message-ID: 20120728165045.18402.62018 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105773/
-----------------------------------------------------------

Review request for kwin, Plasma, Sebastian K=C3=BCgler, Aaron J. Seigo, and=
 Martin Gr=C3=A4=C3=9Flin.

Description
-------

Hello,

With this patch i am adding the QML Aurorae decoration support to the start=
page.
Now the plasmate has a new entry on the startpage with name "KWin Decoratio=
n".
Also it provides a new Aurorae decoration template with every new project.

@Martin The template doesn't simulate switching from active to inactive, cl=
icking buttons etc etc. I will add that support among with the previewer.
@Martin Please take a look at the inline comments...
@ALL i have change the way that the values from the template ($AUTHOR,$EMAI=
L,$DATE etc) are being changed. What did you think? Did you find any issue?

Diffs
-----

  editors/metadata/metadataeditor.cpp 7dffc23 =

  mainwindow.cpp 1f1f28c =

  startpage.h 30b2845 =

  startpage.cpp 726e43a =

  templates/CMakeLists.txt d7acc81 =

  templates/qml/aurorae/AuroraeDecoration.qml PRE-CREATION =

  templates/qml/aurorae/AuroraePreview.qml PRE-CREATION =

  templates/qml/aurorae/DecorationPreview.qml PRE-CREATION =

  templates/qml/aurorae/mainKWinDecoration.qml PRE-CREATION =

Diff: http://git.reviewboard.kde.org/r/105773/diff/

Testing
-------

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105773/">http://git.reviewboard.kde.org/r/105773/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Sebastian Kügler, Aaron J. Seigo, and Martin \
Gräßlin.</div> <div>By Antonis Tsiapaliokas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

With this patch i am adding the QML Aurorae decoration support to the startpage.
Now the plasmate has a new entry on the startpage with name &quot;KWin \
Decoration&quot;. Also it provides a new Aurorae decoration template with every new \
project.

@Martin The template doesn&#39;t simulate switching from active to inactive, clicking \
buttons etc etc. I will add that support among with the previewer. @Martin Please \
take a look at the inline comments... @ALL i have change the way that the values from \
the template ($AUTHOR,$EMAIL,$DATE etc) are being changed. What did you think? Did \
you find any issue? </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(7dffc23)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(1f1f28c)</span></li>

 <li>startpage.h <span style="color: grey">(30b2845)</span></li>

 <li>startpage.cpp <span style="color: grey">(726e43a)</span></li>

 <li>templates/CMakeLists.txt <span style="color: grey">(d7acc81)</span></li>

 <li>templates/qml/aurorae/AuroraeDecoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>templates/qml/aurorae/AuroraePreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>templates/qml/aurorae/DecorationPreview.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>templates/qml/aurorae/mainKWinDecoration.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105773/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 