[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Port of Plastik to QML
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-07-28 12:49:09
Message-ID: 20120728124909.28634.16959 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105768/
-----------------------------------------------------------
Review request for kwin.
Description
-------
This is the other part to the review request for QML support in Aurorae. Th=
e buttons are a little bit of cheating as they are rendered in C++ through =
an extension plugin.
Currently there are a few regressions compared to the native variant:
* animations are enforced (no option) - I intend to keep it that way
* colored border option is not supported, I'm not really sure what it actua=
lly does
* border sizes are not yet supported - relatively trivial to add
* title alignment option not yet supported
* disable close by double click not yet supported - needs to be added to th=
e general MenuButton component
* explicit button spacer is too small
* corners are not yet rounded
* KWin freezes when starting with this decoration - backtrace shows it's so=
mewhere in the ImageProvider, though I do not yet understand why
Overall the config options are missing, need to investigate how to do that.
Diffs
-----
kwin/clients/aurorae/CMakeLists.txt f5eeb71 =
kwin/clients/aurorae/themes/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikbutton.h PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikplugin.h PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp PRE-CREATION =
kwin/clients/aurorae/themes/plastik/code/qmldir PRE-CREATION =
kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml=
PRE-CREATION =
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml PRE-CREA=
TION =
kwin/clients/aurorae/themes/plastik/package/metadata.desktop PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/105768/diff/
Testing
-------
Screenshots
-----------
Old and new Plastik
http://git.reviewboard.kde.org/r/105768/s/648/
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105768/">http://git.reviewboard.kde.org/r/105768/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the other part to the review request for QML support in Aurorae. \
The buttons are a little bit of cheating as they are rendered in C++ through an \
extension plugin.
Currently there are a few regressions compared to the native variant:
* animations are enforced (no option) - I intend to keep it that way
* colored border option is not supported, I'm not really sure what it actually \
does
* border sizes are not yet supported - relatively trivial to add
* title alignment option not yet supported
* disable close by double click not yet supported - needs to be added to the general \
MenuButton component
* explicit button spacer is too small
* corners are not yet rounded
* KWin freezes when starting with this decoration - backtrace shows it's \
somewhere in the ImageProvider, though I do not yet understand why
Overall the config options are missing, need to investigate how to do that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/CMakeLists.txt <span style="color: \
grey">(f5eeb71)</span></li>
<li>kwin/clients/aurorae/themes/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikbutton.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/plastikplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/code/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105768/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105768/s/648/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/28/plastik-qml-buttons_400x100.png" \
style="border: 1px black solid;" alt="Old and new Plastik" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic