[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: un Q'tile partially max'd clients on startMove(Resize())
From: "Commit Hook" <null () kde ! org>
Date: 2012-07-25 18:29:40
Message-ID: 20120725182940.29637.79276 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105699/#review16406
-----------------------------------------------------------
This review has been submitted with commit 5d23c2c39b99acf059cb12e6aa7ecf14fd039962 \
by Thomas Lübking to branch KDE/4.9.
- Commit Hook
On July 23, 2012, 8:53 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105699/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 8:53 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> This aligns to the behavior of not maximized clients and is required because direct \
> tile -> tile out of a moveResize does not work. Also the client is clearly no \
> longer tiled when it's moved.
> The vertical maximization state is however preserved, what may seem strange:
> you've a "vertically max'd window on the left edge, move it somewhere else, then \
> attempt to vertically maximize it and by this restore it to the restore size which \
> is, because of the interim tiling, the same one. We should consider to withdraw the \
> (partial) maximization state with entering a QuickTile mode.
>
> This addresses bug 303937.
> http://bugs.kde.org/show_bug.cgi?id=303937
>
>
> Diffs
> -----
>
> kwin/geometry.cpp 9d15860
>
> Diff: http://git.reviewboard.kde.org/r/105699/diff/
>
>
> Testing
> -------
>
> Yes, could reproduce the bug with assumed required v. maximization - gone with the \
> patch, the window (just) restores it's size instead (which may horizontally differ) \
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105699/">http://git.reviewboard.kde.org/r/105699/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5d23c2c39b99acf059cb12e6aa7ecf14fd039962 by Thomas Lübking to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 23rd, 2012, 8:53 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated July 23, 2012, 8:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This aligns to the behavior of not maximized clients and is required \
because direct tile -> tile out of a moveResize does not work. Also the client is \
clearly no longer tiled when it's moved.
The vertical maximization state is however preserved, what may seem strange:
you've a "vertically max'd window on the left edge, move it somewhere \
else, then attempt to vertically maximize it and by this restore it to the restore \
size which is, because of the interim tiling, the same one. We should consider to \
withdraw the (partial) maximization state with entering a QuickTile mode.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, could reproduce the bug with assumed required v. maximization - \
gone with the patch, the window (just) restores it's size instead (which may \
horizontally differ)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303937">303937</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/geometry.cpp <span style="color: grey">(9d15860)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic