[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: revert deletion of old_librabry
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-07-25 10:10:49
Message-ID: 20120725101049.22508.80159 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105721/#review16362
-----------------------------------------------------------
NOPE.
It's not that simple. Reason is a simple dangeling pointer in Preview.
It's necessary to manage that by revalidation around any loadPlugin() / \
destroyPreviousPlugin() invokation.
Will have a reliable fix this afternoon.
- Thomas Lübking
On July 25, 2012, 8:02 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105721/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 8:02 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> reason: libraries are not unload unless all all related objects are destructed what \
> means that we used to never actually unload them - double-leak :-(
>
> This addresses bug 304026.
> http://bugs.kde.org/show_bug.cgi?id=304026
>
>
> Diffs
> -----
>
> kwin/libkdecorations/kdecoration_plugins_p.cpp c131a41
>
> Diff: http://git.reviewboard.kde.org/r/105721/diff/
>
>
> Testing
> -------
>
> yes, nevertheless i'd suggest to attempt it locally (try to alter a deco setting -> \
> crash; apply patch -> no crash) for the library unloading is timing critical, ie. \
> the bug was heuristic and eg. suddenly vanished when i flooded the sources with \
> qDebug() statements last night.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105721/">http://git.reviewboard.kde.org/r/105721/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">NOPE. It's not that \
simple. Reason is a simple dangeling pointer in Preview.
It's necessary to manage that by revalidation around any loadPlugin() / \
destroyPreviousPlugin() invokation.
Will have a reliable fix this afternoon.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On July 25th, 2012, 8:02 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated July 25, 2012, 8:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">reason: libraries are not unload unless all all related objects are \
destructed what means that we used to never actually unload them - double-leak :-( \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, nevertheless i'd suggest to attempt it locally (try to alter a \
deco setting -> crash; apply patch -> no crash) for the library unloading is \
timing critical, ie. the bug was heuristic and eg. suddenly vanished when i flooded \
the sources with qDebug() statements last night.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304026">304026</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkdecorations/kdecoration_plugins_p.cpp <span style="color: \
grey">(c131a41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105721/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic