'Re: Review Request: Don't use GL Matrix Stack on OpenGL 2 backend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Don't use GL Matrix Stack on OpenGL 2 backend
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-22 8:15:53
Message-ID: 20120722081553.10825.61085 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105455/#review16195
-----------------------------------------------------------

This review has been submitted with commit 42678c60bd683bcaa54a9f192d92ea28df5ea3ba \
by Martin Gräßlin to branch master.

- Commit Hook

On July 6, 2012, 8:01 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105455/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 8:01 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Don't use GL Matrix Stack on OpenGL 2 backend
> 
> Currently the GL Matrix Stack is also used with OpenGL 2.
> That is pushMatrix, multMatrix and popMatrix are executed
> although this does not influence the rendering at all. The
> OpenGL 1 matrices are not passed to the shaders.
> 
> With this change the calls to the matrix stack are no longer
> executed if the Shader based backend is used. This means we
> have a few less matrix multiplications in the rendering.
> 
> Mostly affects a few effects which have not yet completely be
> ported over to OpenGL 2.
> 
> BUG: 303093
> FIXED-IN: 4.10.0
> 
> 
> This addresses bug 303093.
> http://bugs.kde.org/show_bug.cgi?id=303093
> 
> 
> Diffs
> -----
> 
> kwin/libkwineffects/kwinglutils.cpp e237c1b12ce56e3b9ec18faa5a8f12ff9660516b 
> 
> Diff: http://git.reviewboard.kde.org/r/105455/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105455/">http://git.reviewboard.kde.org/r/105455/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 42678c60bd683bcaa54a9f192d92ea28df5ea3ba by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 6th, 2012, 8:01 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated July 6, 2012, 8:01 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Don&#39;t use GL Matrix Stack on OpenGL 2 backend

Currently the GL Matrix Stack is also used with OpenGL 2.
That is pushMatrix, multMatrix and popMatrix are executed
although this does not influence the rendering at all. The
OpenGL 1 matrices are not passed to the shaders.

With this change the calls to the matrix stack are no longer
executed if the Shader based backend is used. This means we
have a few less matrix multiplications in the rendering.

Mostly affects a few effects which have not yet completely be
ported over to OpenGL 2.

BUG: 303093
FIXED-IN: 4.10.0</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303093">303093</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(e237c1b12ce56e3b9ec18faa5a8f12ff9660516b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105455/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 