'Re: Review Request: Plasmate: Add KWin Effect to the startpage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Plasmate: Add KWin Effect to the startpage
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2012-07-10 14:11:19
Message-ID: 20120710141119.14862.45024 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105453/#review15614
-----------------------------------------------------------

its ok

- Giorgos Tsiapaliwkas

On July 6, 2012, 6:21 p.m., Antonis Tsiapaliokas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105453/
> -----------------------------------------------------------
> =

> (Updated July 6, 2012, 6:21 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> Hello, =

> =

> With this patch i am adding the KWin Effect to the startpage
> =

> =

> Diffs
> -----
> =

>   editors/metadata/metadataeditor.cpp 7dffc23 =

>   mainwindow.cpp 1f1f28c =

>   startpage.h 30b2845 =

>   startpage.cpp 726e43a =

>   templates/CMakeLists.txt d7acc81 =

>   templates/mainKWinEffect.js PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/105453/diff/
> =

> =

> Testing
> -------
> =

> Everything works fine
> =

> =

> Thanks,
> =

> Antonis Tsiapaliokas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105453/">http://git.reviewboard.kde.org/r/105453/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">its ok</pre>  <br />

<p>- Giorgos</p>

<br />
<p>On July 6th, 2012, 6:21 p.m., Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated July 6, 2012, 6:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello, 

With this patch i am adding the KWin Effect to the startpage</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything works fine</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(7dffc23)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(1f1f28c)</span></li>

 <li>startpage.h <span style="color: grey">(30b2845)</span></li>

 <li>startpage.cpp <span style="color: grey">(726e43a)</span></li>

 <li>templates/CMakeLists.txt <span style="color: grey">(d7acc81)</span></li>

 <li>templates/mainKWinEffect.js <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105453/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 