[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Plasmate: Add KWin Scripting support to the startpage
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-06-18 20:04:15
Message-ID: 20120618200415.17465.88602 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105238/#review14858
-----------------------------------------------------------
editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/105238/#comment11673>
coding style: missing whitespace after ,
mainwindow.cpp
<http://git.reviewboard.kde.org/r/105238/#comment11669>
I highly recommend to refactor that code, it does not scale anymore. Th=
e ?: is good for one question but not for - what are that? - four.
mainwindow.cpp
<http://git.reviewboard.kde.org/r/105238/#comment11670>
same applies to this section, and you can notice at the indentation of =
the comment that something is wrong here ;-)
startpage.cpp
<http://git.reviewboard.kde.org/r/105238/#comment11671>
sure you want to use a plasma icon?
startpage.cpp
<http://git.reviewboard.kde.org/r/105238/#comment11672>
plasma icon?
templates/mainKWinScript.js
<http://git.reviewboard.kde.org/r/105238/#comment11675>
we have a few examples in kde-examples. Maybe something from there migh=
t be a better template.
=
Also it might be nice to add a comment with link to documentation into =
the template.
- Martin Gr=C3=A4=C3=9Flin
On June 13, 2012, 9:12 a.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105238/
> -----------------------------------------------------------
> =
> (Updated June 13, 2012, 9:12 a.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> Hello,
> =
> This is the task of the 4th week of my GSoC.
> In this patch i am adding a new entry to the starpage of the plasmate for=
the KWin Scripting.
> =
> ISSUES:
> =
> 1)in the "showInteractiveKWinConsole", the icon of the application is the=
"plasma", but i guess that we don't want the plasma icon for the effects.
> Any suggestions?
> 2)I have not add a QML template for scripting because i cannot find one. =
Do you know if there is any?
> =
> =
> Diffs
> -----
> =
> editors/metadata/metadataeditor.cpp 3fe79c2 =
> mainwindow.cpp 6e48940 =
> startpage.h 3ae94c4 =
> startpage.cpp bc333d4 =
> templates/CMakeLists.txt 043eeb8 =
> templates/mainKWinScript.js PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/105238/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105238/">http://git.reviewboard.kde.org/r/105238/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67480#file67480line126" \
style="color: black; font-weight: bold; text-decoration: \
underline;">editors/metadata/metadataeditor.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MetaDataEditor::readFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">126</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">view</span><span class="o">-></span><span \
class="n">type_combo</span><span class="o">-></span><span \
class="n">insertItem</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"KWin Script"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">coding \
style: missing whitespace after ,</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67481#file67481line678" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MainWindow::loadProject(const QString &path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">678</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span \
class="n">actualType</span> <span class="o">=</span> <span \
class="n">types</span><span class="p">.</span><span class="n">isEmpty</span><span \
class="p">()</span> <span class="o">?</span> <span class="n">QString</span><span \
class="p">()</span> <span class="o">:</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">678</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span \
class="n">actualType</span> <span class="o">=</span> <span \
class="n">types</span><span class="p">.</span><span class="n">isEmpty</span><span \
class="p">()</span> <span class="o">?</span> <span class="n">QString</span><span \
class="p">()</span> <span class="o">:</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">679</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/WindowSwitcher"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"Plasma/Applet"</span> <span \
class="o">:</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">679</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/WindowSwitcher"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"Plasma/Applet"</span> <span \
class="o">:</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">680</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/Script"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"Plasma/Applet"</span> <span \
class="o">:</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">680</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"Plasma/Applet"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"Plasma/Applet"</span> <span \
class="o">:</span> <span class="n">types</span><span class="p">.</span><span \
class="n">first</span><span class="p">();</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">681</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"Plasma/Applet"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"Plasma/Applet"</span> <span \
class="o">:</span> <span class="n">types</span><span class="p">.</span><span \
class="n">first</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I highly \
recommend to refactor that code, it does not scale anymore. The ?: is good for one \
question but not for - what are that? - four.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67481#file67481line684" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MainWindow::loadProject(const QString &path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">683</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/WindowSwitcher"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"KWin/WindowSwitcher"</span> <span \
class="o">:</span><span class="hl"> </span><span class="n"><span \
class="hl">actualType</span></span><span class="p"><span \
class="hl">;</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">684</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/WindowSwitcher"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"KWin/WindowSwitcher"</span> <span \
class="o">:</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">685</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//KWin Scripts doesn't have a previewer but</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">686</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//we want the previewer to store their type</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">687</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//because we will not use it on \
MainWindow::createPreviewerFor,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">688</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//so the previewer will be disable</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">689</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">types</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"KWin/Script"</span><span class="p">)</span> <span \
class="o">?</span> <span class="s">"KWin/Script"</span> <span \
class="o">:</span><span class="n">actualType</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same \
applies to this section, and you can notice at the indentation of the comment that \
something is wrong here ;-)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67483#file67483line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StartPage::setupWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">new</span> <span class="n">QListWidgetItem</span><span \
class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span \
class="s">"application-x-plasma"</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span class="s">"KWin \
Script"</span><span class="p">),</span> <span class="n">m_ui</span><span \
class="p">.</span><span class="n">contentTypes</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure you \
want to use a plasma icon?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67483#file67483line340" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StartPage::refreshRecentProjectsList()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">340</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">defaultIconName</span> <span class="o">=</span> <span \
class="s">"plasma"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasma \
icon?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67485#file67485line19" \
style="color: black; font-weight: bold; text-decoration: \
underline;">templates/mainKWinScript.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">19</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kd">function</span> <span class="nx">isVideoPlayer</span><span \
class="p">(</span><span class="nx">client</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we have a \
few examples in kde-examples. Maybe something from there might be a better template.
Also it might be nice to add a comment with link to documentation into the \
template.</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On June 13th, 2012, 9:12 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated June 13, 2012, 9:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This is the task of the 4th week of my GSoC.
In this patch i am adding a new entry to the starpage of the plasmate for the KWin \
Scripting.
ISSUES:
1)in the "showInteractiveKWinConsole", the icon of the application is the \
"plasma", but i guess that we don't want the plasma icon for the \
effects. Any suggestions?
2)I have not add a QML template for scripting because i cannot find one. Do you know \
if there is any?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(3fe79c2)</span></li>
<li>mainwindow.cpp <span style="color: grey">(6e48940)</span></li>
<li>startpage.h <span style="color: grey">(3ae94c4)</span></li>
<li>startpage.cpp <span style="color: grey">(bc333d4)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(043eeb8)</span></li>
<li>templates/mainKWinScript.js <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105238/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic