[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Plasmate: Add Tabbox support to the startpage
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-05-24 13:16:52
Message-ID: 20120524131652.11162.42302 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> >
There is still a big issue here.
The template of the tabbox that i have put is located in the \
kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed \
becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
Also i will update my diff, but for a quicker review please look at my comments :)
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > startpage.cpp, line 146
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line146>
> >
> > I would use a kwin icon for TabBox and I think TabBox is a really, really bad \
> > name.
> > I tend to call it "Window Switcher", the KCM is called "Task Switcher"
I have change the "Tabbox" to "Window Switcher".
As regards the icon, i am sorry for that but i have not change it because i have an \
issue with my kde environmnet and i cannot open a new KDE session.
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > startpage.cpp, line 332
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line332>
> >
> > be aware of correct writing: KWin/TabBox would be the way it is called inside \
> > KWin.
I have change it to "Kwin/WindowSwitcher"...
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote:
> > templates/mainTabbox.qml, line 5
> > <http://git.reviewboard.kde.org/r/105011/diff/1/?file=65129#file65129line5>
> >
> > you should fill in the copyright :-)
On startpage.cpp:466 we replacing the $AUTHOR and the $EMAIL with the real values \
which they have been provided by the user.
- Antonis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105011/#review14107
-----------------------------------------------------------
On May 23, 2012, 5:20 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105011/
> -----------------------------------------------------------
>
> (Updated May 23, 2012, 5:20 a.m.)
>
>
> Review request for kwin, Plasma and Martin Gräßlin.
>
>
> Description
> -------
>
> Hello,
>
> This is the first task of my GSoC. I have add the tabbox support to the startpage \
> of the plasmate.
> NOTES:
>
> 1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because the \
> Plasma::PackageStructure requires the "Plasma/Applet" in order to be able to be \
> used. Also the plasmapkg and the plasmoidview require the "Plasma/Applet" service \
> type. 2)Some lines doesn't have any differences because i have remove some \
> whitespaces and "tabs"...
> ISSUES:
>
> 1)The icons for the tabbox are wrong. I have some issues with my PCs and i cannot \
> open a new session of the KDE. So i wasn't able to find the icon. Sorry for that.
> 2)The template of the tabbox that i have put is located in the \
> kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be \
> installed becuase it uses some Q_PROPERTY elements. Any ideas about how to fix \
> that? 3)I think that the starting comments of the tabbox should become better. I \
> would prefer something like the "mainPlasmoid.qml"....
>
> Diffs
> -----
>
> templates/CMakeLists.txt 6a82772
> templates/mainTabbox.qml PRE-CREATION
> startpage.h 0df4c21
> startpage.cpp 9774b48
> editors/metadata/metadataeditor.cpp fce65fd
> editors/editpage.cpp a331ae5
>
> Diff: http://git.reviewboard.kde.org/r/105011/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/105011/s/574/
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105011/">http://git.reviewboard.kde.org/r/105011/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is still a big \
issue here.
The template of the tabbox that i have put is located in the \
kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed \
becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
Also i will update my diff, but for a quicker review please look at my comments :) \
</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 24th, 2012, 6:46 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line146" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StartPage::setupWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">146</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">new</span> <span class="n">QListWidgetItem</span><span \
class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span \
class="s">"application-x-plasma"</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span \
class="s">"Tabbox"</span><span class="p">),</span> <span \
class="n">m_ui</span><span class="p">.</span><span class="n">contentTypes</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would use a kwin icon \
for TabBox and I think TabBox is a really, really bad name.
I tend to call it "Window Switcher", the KCM is called "Task \
Switcher"</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
change the "Tabbox" to "Window Switcher".
As regards the icon, i am sorry for that but i have not change it because i have an \
issue with my kde environmnet and i cannot open a new KDE session.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 24th, 2012, 6:46 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105011/diff/1/?file=65127#file65127line332" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StartPage::refreshRecentProjectsList()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">332</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span \
class="p">(</span><span class="n">serviceTypes</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"Kwin/Tabbox"</span><span class="p">))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">be aware of correct \
writing: KWin/TabBox would be the way it is called inside KWin.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
change it to "Kwin/WindowSwitcher"...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 24th, 2012, 6:46 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105011/diff/1/?file=65129#file65129line5" \
style="color: black; font-weight: bold; text-decoration: \
underline;">templates/mainTabbox.qml</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">5</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Copyright (C) \
2011 $AUTHOR <$EMAIL></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you should fill in the \
copyright :-)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On \
startpage.cpp:466 we replacing the $AUTHOR and the $EMAIL with the real values which \
they have been provided by the user.</pre> <br />
<p>- Antonis</p>
<br />
<p>On May 23rd, 2012, 5:20 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 23, 2012, 5:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This is the first task of my GSoC. I have add the tabbox support to the startpage of \
the plasmate.
NOTES:
1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because \
the Plasma::PackageStructure requires the "Plasma/Applet" in order to be \
able to be used. Also the plasmapkg and the plasmoidview require the \
"Plasma/Applet" service type. 2)Some lines doesn't have any differences \
because i have remove some whitespaces and "tabs"...
ISSUES:
1)The icons for the tabbox are wrong. I have some issues with my PCs and i cannot \
open a new session of the KDE. So i wasn't able to find the icon. Sorry for that.
2)The template of the tabbox that i have put is located in the \
kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed \
becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that? 3)I think \
that the starting comments of the tabbox should become better. I would prefer \
something like the "mainPlasmoid.qml"....
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>templates/CMakeLists.txt <span style="color: grey">(6a82772)</span></li>
<li>templates/mainTabbox.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>startpage.h <span style="color: grey">(0df4c21)</span></li>
<li>startpage.cpp <span style="color: grey">(9774b48)</span></li>
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(fce65fd)</span></li>
<li>editors/editpage.cpp <span style="color: grey">(a331ae5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105011/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105011/s/574/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/22/tabbox_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic