[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Plasmate: Add Tabbox support to the startpage
From:       Sebastian =?ISO-8859-1?Q?K=FCgler?= <sebas () kde ! org>
Date:       2012-05-23 12:29:08
Message-ID: 3938878.W5fEtBWHol () miro
[Download RAW message or body]

On Wednesday, May 23, 2012 05:20:25 Antonis Tsiapaliokas wrote:
> 2)Some lines doesn't have any differences
> because i have remove some whitespaces and "tabs"...

In the future, please put them in a separate patch, that makes reviewing a lot 
easier.

> 1)The icons for the tabbox are wrong. I have some issues with my PCs and i
> cannot open a new session of the KDE. So i wasn't able to find the icon.
> Sorry for that.
> 2)The template of the tabbox that i have put is located in the
> kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be
> installed becuase it uses some Q_PROPERTY elements. Any ideas about how to
> fix that? 
> 3)I think that the starting comments of the tabbox should become
> better. I would prefer something like the "mainPlasmoid.qml"....

We use main.qml pretty consistently, what's your rationale to make it 
different?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]