[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Swap vsync order, trade in 1frame lag, try harder to detect nvidia framerate (re
From: "Commit Hook" <null () kde ! org>
Date: 2012-05-17 9:55:47
Message-ID: 20120517095547.5446.38556 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103058/#review13910
-----------------------------------------------------------
This review has been submitted with commit ffbde1037ab0f395b5062f55c19e932e=
0cb61cdf by Thomas L=C3=BCbking to branch master.
- Commit Hook
On May 10, 2012, 6:39 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103058/
> -----------------------------------------------------------
> =
> (Updated May 10, 2012, 6:39 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> This performs a paint & glFlush immediately after the buffer swapping and=
defers the next swapping to the next anticipated frame (or idling)
> The behavior is still not as deterministic as we hoped to be since we can=
not measure the time for the actual vsync :\
> I set a fuzzyness of 6ms what leads to a majority of 2-3ms times in waits=
ync but single wait times up to 8 or 9ms occur (what ultimately can be part=
of the syncing itself)
> =
> There's some debug code to print lagging.
> =
> TODO:
> - attempt egl support
> - probably lie to the effects about the time
> =
> =
> Diffs
> -----
> =
> kwin/composite.cpp 7e48066 =
> kwin/libkwineffects/kwinglutils_funcs.h a2c047b =
> kwin/libkwineffects/kwinglutils_funcs.cpp 6d79507 =
> kwin/options.h e89d02b =
> kwin/options.cpp 6188299 =
> kwin/scene.h c7e462f =
> kwin/scene.cpp ff6aec7 =
> kwin/scene_opengl.h 7cf3b6c =
> kwin/scene_opengl.cpp 2ff2938 =
> kwin/scene_opengl_egl.cpp 87690bf =
> kwin/scene_opengl_glx.cpp 1ec5763 =
> kwin/scene_xrender.h 98c4b3b =
> kwin/scene_xrender.cpp 265825c =
> kwin/workspace.h 34114cb =
> kwin/workspace.cpp 466aace =
> =
> Diff: http://git.reviewboard.kde.org/r/103058/diff/
> =
> =
> Testing
> -------
> =
> I've used a CRT for testing which can sync every 11ms ie. 85Hz and lowere=
d the maxFPS down to 10fps with pretty constant results for the time lost w=
aiting for the sync.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103058/">http://git.reviewboard.kde.org/r/103058/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ffbde1037ab0f395b5062f55c19e932e0cb61cdf by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On May 10th, 2012, 6:39 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated May 10, 2012, 6:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This performs a paint & glFlush immediately after the buffer \
swapping and defers the next swapping to the next anticipated frame (or idling) The \
behavior is still not as deterministic as we hoped to be since we cannot measure the \
time for the actual vsync :\ I set a fuzzyness of 6ms what leads to a majority of \
2-3ms times in waitsync but single wait times up to 8 or 9ms occur (what ultimately \
can be part of the syncing itself)
There's some debug code to print lagging.
TODO:
- attempt egl support
- probably lie to the effects about the time</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've used a CRT for testing which can sync every 11ms ie. 85Hz and \
lowered the maxFPS down to 10fps with pretty constant results for the time lost \
waiting for the sync.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(7e48066)</span></li>
<li>kwin/libkwineffects/kwinglutils_funcs.h <span style="color: \
grey">(a2c047b)</span></li>
<li>kwin/libkwineffects/kwinglutils_funcs.cpp <span style="color: \
grey">(6d79507)</span></li>
<li>kwin/options.h <span style="color: grey">(e89d02b)</span></li>
<li>kwin/options.cpp <span style="color: grey">(6188299)</span></li>
<li>kwin/scene.h <span style="color: grey">(c7e462f)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(ff6aec7)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(7cf3b6c)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(2ff2938)</span></li>
<li>kwin/scene_opengl_egl.cpp <span style="color: grey">(87690bf)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(1ec5763)</span></li>
<li>kwin/scene_xrender.h <span style="color: grey">(98c4b3b)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(265825c)</span></li>
<li>kwin/workspace.h <span style="color: grey">(34114cb)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(466aace)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103058/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic