[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: send mouse events translated from touch event to the tabbox embedding window
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-05-03 8:28:29
Message-ID: 20120503082829.1526.38359 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 3, 2012, 7:57 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > what's the state of this review request? Remember there is soft freeze =
today and if you need it for PA time is short :-)
eeh, not sure if this really should go in...
this is really really ugly and still not perfectly working...
if you don't have issues of this code landing in kwin i can push it, but i =
won't try to force a thing like that in the code for sure :p
there were also an issue about dependency from xi2 iirc?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104095/#review13303
-----------------------------------------------------------
On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104095/
> -----------------------------------------------------------
> =
> (Updated Feb. 27, 2012, 4:54 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> on systems with multitouch support, x11Event() won't get any mouse event =
(even for actual mouse events) but will get only xi2 events.
> this translates those xi2 events to mouse events and sends them to the em=
bedding window, making possible to drag the embedding window on multitouch =
systems.
> =
> =
> Diffs
> -----
> =
> kwin/tabbox/declarative.cpp 60effb9e =
> =
> Diff: http://git.reviewboard.kde.org/r/104095/diff/
> =
> =
> Testing
> -------
> =
> the problem could be dependency from xi2.
> however i think that x11Event() not getting mouse events can potentially =
cause problems elsewhere too, focus assignment after click seems a bit bugg=
y on multitouch systems
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104095/">http://git.reviewboard.kde.org/r/104095/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 3rd, 2012, 7:57 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">what's the state of this review request? Remember there is soft \
freeze today and if you need it for PA time is short :-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">eeh, not sure if this \
really should go in... this is really really ugly and still not perfectly working...
if you don't have issues of this code landing in kwin i can push it, but i \
won't try to force a thing like that in the code for sure :p
there were also an issue about dependency from xi2 iirc?</pre>
<br />
<p>- Marco</p>
<br />
<p>On February 27th, 2012, 4:54 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">on systems with multitouch support, x11Event() won't get any mouse \
event (even for actual mouse events) but will get only xi2 events. this translates \
those xi2 events to mouse events and sends them to the embedding window, making \
possible to drag the embedding window on multitouch systems.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the problem could be dependency from xi2. however i think that \
x11Event() not getting mouse events can potentially cause problems elsewhere too, \
focus assignment after click seems a bit buggy on multitouch systems</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(60effb9e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic